-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-736] Upgrade PerimeterX #1822
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… linked binaries phase as well.
…ios, library and ksapi, otherwise app crashes on launch This might change in the future as we update our versions to 3.x
Codecov Report
@@ Coverage Diff @@
## main #1822 +/- ##
==========================================
- Coverage 84.35% 84.35% -0.01%
==========================================
Files 1276 1276
Lines 115436 115447 +11
Branches 30738 30744 +6
==========================================
+ Hits 97381 97388 +7
- Misses 16988 16992 +4
Partials 1067 1067
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SwiftFormat found issues:
Generated by 🚫 Danger |
Old PR, replaced by this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
We recently saw production issues related to PerimeterX captcha page not appearing when users tried to login.
Upon investigation we found issues with
PBXController
launching on iOS 16.4. This eventually went away, but we are 2 major version back of the dependency, so it's probably a good time to upgrade it.Going from 1.13.9 to 3.0.3
🤔 Why && 🛠 How
Summary above. For more detail please read documentation.
✅ Acceptance criteria
AppEnvironment
setup.⏰ TODO