Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-736] Upgrade PerimeterX #1822

Closed
wants to merge 6 commits into from
Closed

[MBL-736] Upgrade PerimeterX #1822

wants to merge 6 commits into from

Conversation

msadoon
Copy link
Contributor

@msadoon msadoon commented May 17, 2023

📲 What

We recently saw production issues related to PerimeterX captcha page not appearing when users tried to login.
Upon investigation we found issues with PBXController launching on iOS 16.4. This eventually went away, but we are 2 major version back of the dependency, so it's probably a good time to upgrade it.

Going from 1.13.9 to 3.0.3

🤔 Why && 🛠 How

Summary above. For more detail please read documentation.

✅ Acceptance criteria

  • PerimeterX 3.0.3 is implemented as per SDK instructions, taking into account our custom types and AppEnvironment setup.

⏰ TODO

  • Ensure we do the required validation as per the SDK instructions. Specific instructions in the document above.

…ios, library and ksapi, otherwise app crashes on launch

This might change in the future as we update our versions to 3.x
@msadoon msadoon self-assigned this May 17, 2023
@msadoon msadoon added this to the release-5.8.0 milestone May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #1822 (ba3f58f) into main (7015f3b) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
- Coverage   84.35%   84.35%   -0.01%     
==========================================
  Files        1276     1276              
  Lines      115436   115447      +11     
  Branches    30738    30744       +6     
==========================================
+ Hits        97381    97388       +7     
- Misses      16988    16992       +4     
  Partials     1067     1067              
Impacted Files Coverage Δ
KsApi/px/PerimeterXTypes.swift 20.00% <28.57%> (+20.00%) ⬆️
KsApi/px/MockPerimeterXTypes.swift 83.33% <33.33%> (-6.67%) ⬇️
KsApi/px/PerimeterXClient.swift 81.39% <50.00%> (-3.23%) ⬇️
KsApi/Service.swift 9.39% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msadoon msadoon modified the milestones: release-5.8.0, release-5.9.0 May 18, 2023
@msadoon msadoon added the blocked a PR that is blocked for external reasons label Jun 29, 2023
@nativeksr
Copy link
Collaborator

1 Warning
⚠️ Big PR

SwiftFormat found issues:

File Rules
Kickstarter-iOS/AppDelegate.swift:34:1 warning: (blankLinesAtStartOfScope) Remove leading blank line at the start of a scope.
Kickstarter-iOS/AppDelegate.swift:38:1 warning: (wrap) Wrap lines that exceed the specified maximum width.
Kickstarter-iOS/AppDelegate.swift:40:1 warning: (indent) Indent code in accordance with the scope level.
Kickstarter-iOS/AppDelegate.swift:97:1 warning: (indent) Indent code in accordance with the scope level.
Kickstarter-iOS/AppDelegate.swift:100:1 warning: (blankLinesAtStartOfScope) Remove leading blank line at the start of a scope.
Kickstarter-iOS/AppDelegate.swift:102:1 warning: (spaceInsideComments) Add leading and/or trailing space inside comments.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:134:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:146:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:157:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:168:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:179:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:189:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:219:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:230:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:253:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:265:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:277:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:289:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
Kickstarter-iOS/Features/DebugPushNotifications/Controller/DebugPushNotificationsViewController.swift:302:1 warning: (spaceAroundOperators) Add or remove space around operators or delimiters.
KsApi/ServiceType.swift:483:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/ServiceType.swift:498:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/extensions/ApolloClient+ErrorHandler.swift:1:1 warning: (sortedImports) Sort import statements alphabetically.
KsApi/extensions/ApolloClient+ErrorHandler.swift:2:1 warning: (sortedImports) Sort import statements alphabetically.
KsApi/extensions/ApolloClient+ErrorHandler.swift:3:1 warning: (sortedImports) Sort import statements alphabetically.
KsApi/extensions/ApolloClient+ErrorHandler.swift:4:1 warning: (sortedImports) Sort import statements alphabetically.
KsApi/extensions/ApolloClient+ErrorHandler.swift:16:1 warning: (blankLinesAtStartOfScope) Remove leading blank line at the start of a scope.
KsApi/extensions/ApolloClient+RAC.swift:61:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/extensions/ApolloClient+RAC.swift:66:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/extensions/NSURLSession.swift:36:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/extensions/NSURLSession.swift:38:1 warning: (wrap) Wrap lines that exceed the specified maximum width.
KsApi/extensions/NSURLSession.swift:39:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:6:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:26:1 warning: (spaceInsideComments) Add leading and/or trailing space inside comments.
KsApi/px/PerimeterXClient.swift:27:1 warning: (spaceInsideComments) Add leading and/or trailing space inside comments.
KsApi/px/PerimeterXClient.swift:28:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:31:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:42:1 warning: (spaceInsideComments) Add leading and/or trailing space inside comments.
KsApi/px/PerimeterXClient.swift:43:1 warning: (spaceInsideComments) Add leading and/or trailing space inside comments.
KsApi/px/PerimeterXClient.swift:45:1 warning: (spaceInsideComments) Add leading and/or trailing space inside comments.
KsApi/px/PerimeterXClient.swift:48:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:49:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:51:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:51:1 warning: (spaceInsideComments) Add leading and/or trailing space inside comments.
KsApi/px/PerimeterXClient.swift:74:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:75:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:76:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXClient.swift:80:1 warning: (indent) Indent code in accordance with the scope level.
KsApi/px/PerimeterXTypes.swift:9:1 warning: (trailingSpace) Remove trailing space at end of a line.
KsApi/px/PerimeterXTypes.swift:12:1 warning: (trailingSpace) Remove trailing space at end of a line.
Library/AppEnvironment.swift:62:1 warning: (blankLinesBetweenScopes) Insert blank line before class, struct, enum, extension, protocol or function declarations.

Generated by 🚫 Danger

@msadoon msadoon modified the milestones: release-5.9.0, 5.10.0 Jul 25, 2023
@msadoon msadoon mentioned this pull request Jul 26, 2023
2 tasks
@msadoon
Copy link
Contributor Author

msadoon commented Jul 26, 2023

Old PR, replaced by this one

@msadoon msadoon closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked a PR that is blocked for external reasons enhancement WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants