-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MBL-696] Cleanup Optimizely Experiments #1812
Conversation
…til more I can get more feature context
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! That was a lot! Good work this is a lot of good unused code removal.
A few things:
- Go through each comment and write a commit for it specifically, that'll make the changes easier to review.
- Mostly on me, but if a PR ever becomes big like this earlier on in the coding just use best judgement and split it up. I think we both enjoy reading smaller more focused PRs.
Awesome. Launch the app and ensure the features are all working as expected. I suspect they should be fine. I'll do the same on my end after the PR is ready to merge.
…nOnboarding output, and LandingViewController/LandingViewModel and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok a few more things to cover. I guess the biggest thing is to remove the screenshots from any view controller we delete. Those image files are big and lots of them exist for each test and there are many per test. Good opportunity for clean up!
The unresolved comments are the only things left...most of them should be straightforward, ping me if there's anything confusing.
Kickstarter-iOS/Features/ThanksProjects/Datasource/ThanksProjectsDataSource.swift
Show resolved
Hide resolved
…tarter/ios-oss into scott/clean-up-experiments
…MessagingControlEnabled
@msadoon ok sorry about the missed comments. each should be addressed now. I just had one question about the removal of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, great work - this is a lot of unused code removed and excellent clean up.
I tested the feature flags - campaign, Stripe payment sheets - they are all still on. Maybe do a quick smoke test yourself of sign up flow.
📲 What
Remove all old optimizely experiments from the source code.
🤔 Why
Removing Optimizely saves us an expensive subscription that can be replaced for free by more useful tools like Firebase Remote Config.
🛠 How
Removed each experiment commit by commit.
Each commit shows the removal of the experiment as well as as updates to corresponding tests and associated code. For example, removing the
nativeOnboarding
experiment renders the goToLanding flow/page unused. That code has been removed as well as the experiment (see the last commit for these changes).This is the list of the current experiments living in the code, everything is unit tested.
native_onboarding_series_new_backers
onboarding_category_personalization_flow
native_project_cards
native_risk_messaging
OptimizelyExperiment.swift
as well asgetVariationKey()
fromOptimizelyClientType
I identified the control variant and integrated it properly outside the experiment.
The following landing page classes have been deleted.
If we want to add a landing page flow back in we can rebuild with SwiftUI/Combine
I did not address the
native_risk_messaging
associated code because I'd like more context on that feature's expected behavior first.✅ Acceptance criteria
I suggest reviewing this commit by commit to better understand the impact of each experiment.