-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-983] Prelaunch Page Existing Project Page UI #1797
[WEB-983] Prelaunch Page Existing Project Page UI #1797
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
==========================================
- Coverage 85.36% 85.35% -0.01%
==========================================
Files 1286 1286
Lines 117624 117942 +318
Branches 31142 31232 +90
==========================================
+ Hits 100411 100673 +262
- Misses 16129 16183 +54
- Partials 1084 1086 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Generated by 🚫 Danger |
…ign tab was showing images if they were downloaded before the user went to campaign tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Noticed a bug when going to profile to view the saved prelaunch project.
- The number of saved projects doesn't update
- The list of saved projects is not updating until forcing a pull-to-refresh (maybe that's a known one)
Also, I'm still reviewing the string translation updates. It might be easier to put changes like that in a separate PR in the future to keep these smaller.
Ok, yea good point, just given the timelines wanted this quickly merged with Strings. Plus the Strings are related to the context here. Also regarding the saved projects not updating until refreshed -- it's an upcoming ticket here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
📲 What
We want to enabled prelaunch projects to show a different UI to what is there now (looks broken.)
🤔 Why
Deeplinks are used in marketing campaigns to display projects to the user in-app. Those in-app projects are sometimes prelaunch, so they have no backer/pledge/comments/updates info.
As of now prelaunch project deeplinks open (sometimes) in the app. We want to make them always open in-app and fix-up the UI to display the project page as intended design.
🛠 How
Few pieces here, mainly related to the project's
displayPrelaunch
boolean. PreviouslyAppDelegate
was routing to Safari when that flag was true. It should now route in-app.Needed Project
watchesCount
GQL property to be included in project fragment.Update of Strings.
The main way we save the project is to reuse the
WatchProjectViewModel
in theProjectNavigationSelectorView
. We have thePledgeCTAContainerView
pass the newprelaunch
PledgeCTAType
to that view via delegation - if the button click is from the pledge cta. If not we listen for a notification from the navigation selector when project saves there.That's the cool part, we reuse a lot of existing code and keep the two views nicely in sync.
A minor bug was fixed within the project page, which on orientation change was showing cached images that were directly updated in the table before sections changed from Overview to another tab. So if you loaded a project and immediately changed the orientation, the overview tab shows images that should only be shown in the campaign tab. So nice quick fix there.
👀 See
Simulator.Screen.Recording.-.iPhone.8.-.2023-03-20.at.10.05.06.mp4
✅ Acceptance criteria
⏰ TODO
displayPrelaunch
flag