-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MBL-1016: Add handling for failures in MockGraphQLClient (#1901)
- Loading branch information
1 parent
91c1afe
commit 5e5cae9
Showing
5 changed files
with
111 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
import Combine | ||
@testable import KsApi | ||
import XCTest | ||
|
||
final class MockGraphQLClient_CombineTests: XCTestCase { | ||
func testSuccess() { | ||
let mockClient = MockGraphQLClient() | ||
let observer = CombineTestObserver<UserEnvelope<GraphUserEmail>, ErrorEnvelope>() | ||
|
||
let fetchGraphUserEmailQuery = GraphAPI.FetchUserEmailQuery() | ||
let fetchUserEmailQueryData = GraphAPI.FetchUserEmailQuery | ||
.Data(unsafeResultMap: GraphUserEnvelopeTemplates.userJSONDict) | ||
|
||
guard let envelope = UserEnvelope<GraphUserEmail>.userEnvelope(from: fetchUserEmailQueryData) else { | ||
XCTFail() | ||
return | ||
} | ||
|
||
let publisher: AnyPublisher<UserEnvelope<GraphUserEmail>, ErrorEnvelope> = | ||
mockClient.fetchWithResult(query: fetchGraphUserEmailQuery, result: .success(envelope)) | ||
|
||
observer.observe(publisher) | ||
|
||
XCTAssertEqual(observer.events.count, 1) | ||
|
||
if case let .value(observedEnvelope) = observer.events.last { | ||
XCTAssertEqual(observedEnvelope.me, envelope.me) | ||
} else { | ||
XCTFail() | ||
} | ||
} | ||
|
||
func testFailure() { | ||
let mockClient = MockGraphQLClient() | ||
let observer = CombineTestObserver<UserEnvelope<GraphUserEmail>, ErrorEnvelope>() | ||
|
||
let fetchGraphUserEmailQuery = GraphAPI.FetchUserEmailQuery() | ||
let error = ErrorEnvelope( | ||
errorMessages: ["Something went wrong"], | ||
ksrCode: .GraphQLError, | ||
httpCode: 503, | ||
exception: nil | ||
) | ||
|
||
let publisher: AnyPublisher<UserEnvelope<GraphUserEmail>, ErrorEnvelope> = | ||
mockClient.fetchWithResult(query: fetchGraphUserEmailQuery, result: .failure(error)) | ||
|
||
observer.observe(publisher) | ||
|
||
XCTAssertEqual(observer.events.count, 1) | ||
|
||
if case let .error(observedError) = observer.events.last { | ||
XCTAssertEqual(observedError.ksrCode, error.ksrCode) | ||
XCTAssertEqual(observedError.errorMessages, error.errorMessages) | ||
} else { | ||
XCTFail() | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,13 +31,21 @@ final class ReportProjectFormViewModelTests: TestCase { | |
userEmail.observe(vm.$retrievedEmail) | ||
|
||
XCTAssertEqual(userEmail.events.count, 1) | ||
XCTAssertEqual(userEmail.events.last, Optional.some(nil)) | ||
|
||
if case let .value(value) = userEmail.events.last { | ||
XCTAssertEqual(value, nil) | ||
} | ||
|
||
vm.inputs.viewDidLoad() | ||
self.scheduler.advance() | ||
|
||
XCTAssertEqual(userEmail.events.count, 2) | ||
XCTAssertEqual(userEmail.events.last, Optional("[email protected]")) | ||
|
||
if case let .value(value) = userEmail.events.last { | ||
XCTAssertEqual(value, "[email protected]") | ||
} else { | ||
XCTFail() | ||
} | ||
} | ||
} | ||
|
||
|
@@ -50,14 +58,28 @@ final class ReportProjectFormViewModelTests: TestCase { | |
saveButtonEnabled.observe(vm.$saveButtonEnabled) | ||
|
||
XCTAssertEqual(saveButtonEnabled.events.count, 1) | ||
XCTAssertEqual(saveButtonEnabled.events.last, false) | ||
|
||
if case let .value(value) = saveButtonEnabled.events.last { | ||
XCTAssertEqual(value, false) | ||
} else { | ||
XCTFail() | ||
} | ||
|
||
vm.detailsText = "This is my report. I don't like this project very much." | ||
XCTAssertEqual(saveButtonEnabled.events.count, 2) | ||
XCTAssertEqual(saveButtonEnabled.events.last, true) | ||
if case let .value(value) = saveButtonEnabled.events.last { | ||
XCTAssertEqual(value, true) | ||
} else { | ||
XCTFail() | ||
} | ||
|
||
vm.detailsText = "" | ||
|
||
XCTAssertEqual(saveButtonEnabled.events.count, 3) | ||
XCTAssertEqual(saveButtonEnabled.events.last, false) | ||
if case let .value(value) = saveButtonEnabled.events.last { | ||
XCTAssertEqual(value, false) | ||
} else { | ||
XCTFail() | ||
} | ||
} | ||
} |