Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid potential racing condition #98

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Avoid potential racing condition #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/sns/lib/sns/AbstractSnsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,13 @@ export abstract class AbstractSnsService<
// @ts-ignore
public topicArn: string

private isInitted: boolean
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be more explicit and not rely on implementation detail

private initPromise?: Promise<void>

constructor(dependencies: DependenciesType, options: SNSOptionsType) {
super(dependencies, options)

this.isInitted = false
this.snsClient = dependencies.snsClient
}

Expand All @@ -98,6 +102,7 @@ export abstract class AbstractSnsService<

const initResult = await initSns(this.snsClient, this.locatorConfig, this.creationConfig)
this.topicArn = initResult.topicArn
this.isInitted = true
}

// eslint-disable-next-line @typescript-eslint/require-await
Expand All @@ -108,9 +113,13 @@ export abstract class AbstractSnsService<
messageSchema: ZodSchema<MessagePayloadType>,
options: SNSMessageOptions = {},
): Promise<void> {
if (this.topicArn === undefined) {
// Lazy loading
await this.init()
// If it's not initted yet, do the lazy init
if (!this.isInitted) {
// avoid multiple concurrent inits
if (!this.initPromise) {
this.initPromise = this.init()
}
await this.initPromise
}

try {
Expand Down
15 changes: 12 additions & 3 deletions packages/sqs/lib/sqs/AbstractSqsService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,13 @@ export abstract class AbstractSqsService<
// @ts-ignore
public queueArn: string

private isInitted: boolean
private initPromise?: Promise<void>

constructor(dependencies: DependenciesType, options: SQSOptionsType) {
super(dependencies, options)

this.isInitted = false
this.sqsClient = dependencies.sqsClient
}

Expand All @@ -72,16 +76,21 @@ export abstract class AbstractSqsService<
this.queueArn = queueArn
this.queueUrl = queueUrl
this.queueName = queueName
this.isInitted = true
}

protected async internalPublish(
message: MessagePayloadType,
messageSchema: ZodSchema<MessagePayloadType>,
options: SQSMessageOptions = {},
): Promise<void> {
if (!this.queueArn) {
// Lazy loading
await this.init()
// If it's not initted yet, do the lazy init
if (!this.isInitted) {
// avoid multiple concurrent inits
if (!this.initPromise) {
this.initPromise = this.init()
}
await this.initPromise
}

try {
Expand Down
Loading