Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5046 outbox-core package for transactional outbox pattern #204

Merged
merged 31 commits into from
Sep 16, 2024

Conversation

kamilwylegala
Copy link
Collaborator

@kamilwylegala kamilwylegala commented Sep 4, 2024

Added few classes in outbox.ts that cover:

  • Periodic job that runs every 1 sec to process entries from outbox storage
  • OutboxStorage interface -> next step, implement prisma

I didn't decide to implement lockedUntil for ACKed entries. Now the code that handles entries is wrapped with try-catch, in case of errors we always end up with FAILED status, next execution will pick up such entries until retry count max is reached.

@kamilwylegala kamilwylegala marked this pull request as draft September 4, 2024 10:22
@kamilwylegala kamilwylegala changed the title [WIP] AP-5046 outbox-core package AP-5046 outbox-core package for transactional outbox pattern Sep 5, 2024
@kamilwylegala kamilwylegala marked this pull request as ready for review September 5, 2024 11:48
@kamilwylegala
Copy link
Collaborator Author

@kibertoad Ready for review.

Copy link
Owner

@kibertoad kibertoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive work, thank you so much!

@kamilwylegala
Copy link
Collaborator Author

Very impressive work, thank you so much!

Thank you, let me work on the test pipeline now 😁

@kamilwylegala
Copy link
Collaborator Author

Ready for release @kibertoad 🎉

@jmontoyaa
Copy link

jmontoyaa commented Sep 16, 2024

@kibertoad Could we merge this one? 👉👈

@kibertoad kibertoad merged commit 1faf89b into kibertoad:main Sep 16, 2024
5 checks passed
@kibertoad
Copy link
Owner

@jmontoyaa done. should I publish a new version, or we still need to implement anything for the outbox?

@jmontoyaa
Copy link

Thanks! 🙏 A new version, is not needed at the moment. There's still this PR in draft about the prisma adapter #208

I will mark ticket AP-5046 as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants