AP-4870 async event handlers support #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosGamero
commented
Aug 28, 2024
Merged
CarlosGamero
changed the title
CarlosGamero
commented
Aug 28, 2024
CarlosGamero
commented
Aug 29, 2024
Comment on lines
44
to
48
| CommonEventDefinitionPublisherSchemaType<CommonEventDefinition> = CommonEventDefinitionPublisherSchemaType<CommonEventDefinition>, | ||
| > = { | ||
| readonly eventHandlerId: string | ||
| handleEvent(event: EventDefinitionSchema): void | Promise<void> | ||
| } |
There was a problem hiding this comment.
We need to add this to be able to add observability on bg handlers
CarlosGamero
commented
Aug 29, 2024
Comment on lines
184
to
190
| // not sure if we should use startWithGroup or start, using group to group all handlers for the same event type | ||
| // should it be eventId + eventType or just eventType? | ||
| this.transactionObservabilityManager?.startWithGroup( | ||
| this.buildTransactionKey(event, handler), | ||
| transactionId, | ||
| event.type, | ||
| ) |
There was a problem hiding this comment.
Please share your thoughts 🙏! If you agree I will remove the comment
kibertoad
reviewed
Aug 30, 2024
kibertoad
reviewed
Aug 30, 2024
kibertoad
reviewed
Aug 30, 2024
kibertoad
reviewed
Aug 30, 2024
kibertoad
reviewed
Sep 2, 2024
| background: [], | ||
| } | ||
|
|
||
| const fgHandlers = [...eventHandlers.foreground, ...this.anyHandlers.foreground] |
There was a problem hiding this comment.
it seems a bit wasteful to repopulate this on every event. can we do that after handler is attached instead?
There was a problem hiding this comment.
Discussed on Slack, for visibility:
To avoid creating this array with every event, we moved any handler to eventHandlerMap
There was a problem hiding this comment.
Already done :D
kibertoad
reviewed
Sep 2, 2024
| const transactionId = randomUUID() | ||
| let isSuccessfull = false | ||
| try { | ||
| this.transactionObservabilityManager?.startWithGroup( |
There was a problem hiding this comment.
yeah, I'd say it makes sense to use startWithGroup here
kibertoad
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.