Messages barrier max time #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosGamero
commented
May 9, 2024
CarlosGamero
commented
May 10, 2024
| @@ -30,6 +31,7 @@ import { AbstractSqsService } from './AbstractSqsService' | |||
| const ABORT_EARLY_EITHER: Either<'abort', never> = { | |||
| error: 'abort', | |||
| } | |||
| const DEFAULT_MAX_RETRY_DURATION = 4 * 24 * 60 * 60 // 4 days in seconds | |||
There was a problem hiding this comment.
I think 4 days is the default time a message can be in the queue waiting, will check to make sure
There was a problem hiding this comment.
Confirmed (doc) using the same value on AMQP to have similar behaviour in both, please let me know if you disagree
CarlosGamero
commented
May 10, 2024
kibertoad
reviewed
May 10, 2024
kibertoad
reviewed
May 10, 2024
kibertoad
approved these changes
May 10, 2024
kibertoad
reviewed
May 10, 2024
kibertoad
reviewed
May 10, 2024
kibertoad
reviewed
May 10, 2024
kibertoad
reviewed
May 10, 2024
kibertoad
reviewed
May 10, 2024
Co-authored-by: Igor Savin <[email protected]>
…ibertoad/message-queue-toolkit into feat/messages_barrier_max_time
kibertoad
approved these changes
May 10, 2024
dariacm
approved these changes
May 10, 2024
Co-authored-by: Daria Carlotta Maino <[email protected]>
Co-authored-by: Daria Carlotta Maino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a message fails to be processed, and is there another message waiting for it on the barrier pattern, it will be there waiting forever.
Solution:
retryLaterfeature