Implement PublisherManager convenience wrapper #136
Conversation
kibertoad
commented
May 3, 2024
kibertoad
commented
- Automatically spawn publishers on demand
- Automatically fill metadata fields
|
|
||
| constructor(options: MetadataFillerOptions) { | ||
| this.serviceId = options.serviceId | ||
| this.defaultVersion = options.defaultVersion ?? '1.0.0' |
There was a problem hiding this comment.
Do we want to migrate to SemVer for the schemaVersion field? to me, it sounds like the best approach but asking just to confirm
There was a problem hiding this comment.
Wondering if could be beneficial, on consumer, to differentiate between schemaVersion to use one handler or the other 🤔 (definitely not part of this PR, sorry for raising things not relevant here)
There was a problem hiding this comment.
hmmm, interesting idea! and yes, that would be awesome for the compatibility. will implement in a separate PR
|
|
||
| import { AbstractSnsSqsConsumer } from '../../lib/sns/AbstractSnsSqsConsumer' | ||
|
|
||
| export class FakeConsumer<T extends BaseMessageType> extends AbstractSnsSqsConsumer<T, unknown> { |
There was a problem hiding this comment.
Could make sense to expose this class to provide an easy way to replace real consumers on tests? I am not sure tbh
| handlers: new MessageHandlerConfigBuilder<T, unknown>() | ||
| .addConfig(messageSchema, (message) => this._processMessage(message)) |
There was a problem hiding this comment.
Nit: This could be simplified with
.addConfig(messageSchema, (message) => Promise.resolve({result: 'success'}))
|
Outstanding work 🚀! |
