Visibility timeout heartbeat #124
Conversation
CarlosGamero
changed the title
CarlosGamero
changed the title
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@message-queue-toolkit/sns", | |||
| "version": "12.1.1", | |||
| "version": "13.0.0", | |||
There was a problem hiding this comment.
before we release this version, let's also merge #121, so that we don't need to do semver majors in a row
There was a problem hiding this comment.
Sounds great to me 🙇 I will wait to merge this PR
There was a problem hiding this comment.
feel free to merge, just don't hurry releasing it :D.
After you are done, I will address any conflicts if there are on the other PR, and release both changes
There was a problem hiding this comment.
Ah, right, this repo doesn't have auto-release 😅 sorry, I was confused, thanks for the clarification 🙏
There was a problem hiding this comment.
Merged, please let me know If can help with conflicts or release 🙇
| await consumer2.start() | ||
|
|
||
| // wait for both consumers to process message | ||
| await waitAndRetry(() => consumer1Counter > 0 && consumer2Counter > 0, 100, 40) |
There was a problem hiding this comment.
we should assert that it resolves to true and not just timeouts
There was a problem hiding this comment.
The check is done using counters, in the second each case I don't only want to know it is false, we should check that consumer1 was de only who received the message
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-visibility-timeout.html