Skip to content

Commit

Permalink
biome migration (#202)
Browse files Browse the repository at this point in the history
* s3-payload-store biome migration

* schemas biome migration

* sns biome migration

* SNS lint fixes

* More lint fixes

* Fixing test error
  • Loading branch information
CarlosGamero authored Aug 28, 2024
1 parent 3975100 commit cfa636b
Show file tree
Hide file tree
Showing 37 changed files with 137 additions and 437 deletions.
4 changes: 0 additions & 4 deletions packages/s3-payload-store/.eslintignore

This file was deleted.

80 changes: 0 additions & 80 deletions packages/s3-payload-store/.eslintrc.json

This file was deleted.

2 changes: 0 additions & 2 deletions packages/s3-payload-store/.prettierignore

This file was deleted.

9 changes: 0 additions & 9 deletions packages/s3-payload-store/.prettierrc.json

This file was deleted.

18 changes: 5 additions & 13 deletions packages/s3-payload-store/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"test": "vitest",
"test:coverage": "npm test -- --coverage",
"test:ci": "npm run docker:start:dev && npm run test:coverage && npm run docker:stop:dev",
"lint": "eslint . --ext .ts && tsc --noEmit",
"lint:fix": "prettier --write . && eslint . --ext .ts --fix",
"lint": "biome check . && tsc --project tsconfig.json --noEmit",
"lint:fix": "biome check --write .",
"docker:start:dev": "docker compose up -d",
"docker:stop:dev": "docker compose down",
"prepublishOnly": "npm run build:release"
Expand All @@ -35,15 +35,11 @@
},
"devDependencies": {
"@message-queue-toolkit/core": "*",
"@biomejs/biome": "1.8.3",
"@kibertoad/biome-config": "^1.2.1",
"@types/node": "^22.0.0",
"@typescript-eslint/eslint-plugin": "^8.0.1",
"@typescript-eslint/parser": "^8.0.1",
"@vitest/coverage-v8": "^2.0.4",
"del-cli": "^5.1.0",
"eslint": "^8.57.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-vitest": "0.4.1",
"prettier": "^3.2.5",
"typescript": "^5.5.3",
"vitest": "^2.0.4"
},
Expand All @@ -64,9 +60,5 @@
"store",
"claim-check"
],
"files": [
"README.md",
"LICENSE",
"dist/*"
]
"files": ["README.md", "LICENSE", "dist/*"]
}
4 changes: 2 additions & 2 deletions packages/s3-payload-store/test/store/S3PayloadStore.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Readable } from 'node:stream'

import { S3 } from '@aws-sdk/client-s3'
import { describe, beforeEach, expect, it, beforeAll } from 'vitest'
import { beforeAll, beforeEach, describe, expect, it } from 'vitest'

import { S3PayloadStore } from '../../lib/S3PayloadStore'
import { assertEmptyBucket, getObjectContent, objectExists } from '../utils/s3Utils'
Expand All @@ -14,7 +14,7 @@ describe('S3PayloadStore', () => {
let s3: S3
let store: S3PayloadStore

beforeAll(async () => {
beforeAll(() => {
s3 = new S3(TEST_AWS_CONFIG)
store = new S3PayloadStore({ s3 }, { bucketName: TEST_BUCKET })
})
Expand Down
6 changes: 4 additions & 2 deletions packages/s3-payload-store/test/utils/s3Utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ export async function assertEmptyBucket(s3: S3, bucketName: string) {
if (objects.Contents?.length) {
await s3.deleteObjects({
Bucket: bucketName,
Delete: { Objects: objects.Contents?.map((object) => ({ Key: object.Key })) },
Delete: {
Objects: objects.Contents?.map((object) => ({ Key: object.Key })),
},
})
}
} catch (e) {
Expand All @@ -28,7 +30,7 @@ export async function objectExists(s3: S3, bucket: string, key: string) {
try {
await s3.headObject({ Bucket: bucket, Key: key })
return true
} catch (e) {
} catch (_) {
return false
}
}
4 changes: 0 additions & 4 deletions packages/schemas/.eslintignore

This file was deleted.

80 changes: 0 additions & 80 deletions packages/schemas/.eslintrc.json

This file was deleted.

2 changes: 0 additions & 2 deletions packages/schemas/.prettierignore

This file was deleted.

9 changes: 0 additions & 9 deletions packages/schemas/.prettierrc.json

This file was deleted.

2 changes: 1 addition & 1 deletion packages/schemas/lib/events/baseEventSchemas.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ZodLiteral, ZodObject, ZodOptional, ZodString, ZodRawShape } from 'zod'
import type { ZodLiteral, ZodObject, ZodOptional, ZodRawShape, ZodString } from 'zod'
import { z } from 'zod'

// External message metadata that describe the context in which the message was created, primarily used for debugging purposes
Expand Down
18 changes: 5 additions & 13 deletions packages/schemas/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"scripts": {
"build": "del-cli dist && del-cli coverage && tsc",
"build:release": "del-cli dist && npm run lint && tsc --project tsconfig.release.json",
"lint": "eslint . --ext .ts",
"lint:fix": "prettier --write . && eslint . --ext .ts --fix",
"lint": "biome check . && tsc --project tsconfig.json --noEmit",
"lint:fix": "biome check --write .",
"test:coverage": "",
"test:ci": "",
"docker:start:dev": "",
Expand All @@ -27,14 +27,10 @@
"zod": "^3.23.8"
},
"devDependencies": {
"@biomejs/biome": "1.8.3",
"@kibertoad/biome-config": "^1.2.1",
"@types/node": "^22.0.0",
"@typescript-eslint/eslint-plugin": "^8.0.1",
"@typescript-eslint/parser": "^8.0.1",
"del-cli": "^5.1.0",
"eslint": "^8.57.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-vitest": "0.4.1",
"prettier": "^3.2.5",
"typescript": "^5.5.3"
},
"homepage": "https://github.com/kibertoad/message-queue-toolkit",
Expand All @@ -54,9 +50,5 @@
"rabbitmq",
"rabbit"
],
"files": [
"README.md",
"LICENSE",
"dist/*"
]
"files": ["README.md", "LICENSE", "dist/*"]
}
4 changes: 0 additions & 4 deletions packages/sns/.eslintignore

This file was deleted.

Loading

0 comments on commit cfa636b

Please sign in to comment.