Improve support for mocking dependencies in DI #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
commented
Apr 24, 2024
|
|
||
| declare module 'awilix' { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| interface ResolverOptions<T> { | ||
| asyncInit?: boolean | string | ||
| asyncInitPriority?: number // lower means it gets initted earlier | ||
| asyncDispose?: boolean | string | ((instance: T) => Promise<unknown>) | ||
| asyncDispose?: boolean | string | (<U extends T>(instance: U) => Promise<unknown>) |
There was a problem hiding this comment.
Without this change it wasn't possible to pass a class that would extend the original class as a resolver override.
E. g. something like this:
consumerErrorResolver: asClass(FakeConsumerErrorResolver, SINGLETON_CONFIG),
There was a problem hiding this comment.
Nice! I was just writing up a repro for this! https://codesandbox.io/p/devbox/awilix-ts-interface-j5sll2
kibertoad
commented
Apr 24, 2024
| [Key in keyof TDependencies]: Resolver<TDependencies[Key]> | ||
| } | ||
|
|
||
| export function asMockClass<T = object>( |
There was a problem hiding this comment.
This is for cases when we know that passed class does not fully implement the original class contract, and we are fine with that.
CarlosGamero
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.