Skip to content

Commit

Permalink
[Fleet] Fix package archive bug + reenable Endpoint tests (elastic#14…
Browse files Browse the repository at this point in the history
…3120)

* Reenable endpoint tests to debug in CI

* Revert removal of skip in trusted apps

* Try enabling Fleet debug logs

* Fix missing archive path in bundled packages

* Remove Fleet debug logs in endpoint tests

* Reenable endpoint suites

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
kpollich and kibanamachine authored Oct 14, 2022
1 parent acdfb23 commit d9d10f2
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
11 changes: 10 additions & 1 deletion x-pack/plugins/fleet/server/services/epm/registry/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ export async function getInfo(name: string, version: string) {
// input type packages must get their pkg info from the archive
if (packageInfo.type === 'integration') setPackageInfo({ name, version, packageInfo });
}

return packageInfo as RegistryPackage;
});
}
Expand Down Expand Up @@ -348,9 +349,17 @@ export async function fetchArchiveBuffer({
verificationResult?: PackageVerificationResult;
}> {
const logger = appContextService.getLogger();
const { download: archivePath } = await getInfo(pkgName, pkgVersion);
let { download: archivePath } = await getInfo(pkgName, pkgVersion);

// Bundled packages don't have a download path when they're installed, as they're
// ArchivePackage objects - so we fake the download path here instead
if (!archivePath) {
archivePath = `/epr/${pkgName}/${pkgName}-${pkgVersion}.zip`;
}

const archiveUrl = `${getRegistryUrl()}${archivePath}`;
const archiveBuffer = await getResponseStream(archiveUrl).then(streamToBuffer);

if (shouldVerify) {
const verificationResult = await verifyPackageArchiveSignature({
pkgName,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const esClient = getService('es');
const unzipPromisify = promisify(unzip);

describe.skip('For each artifact list under management', function () {
describe('For each artifact list under management', function () {
let indexedData: IndexedHostsAndAlertsResponse;

const checkFleetArtifacts = async (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const endpointTestResources = getService('endpointTestResources');
const policyTestResources = getService('policyTestResources');

describe.skip('Endpoint permissions:', () => {
describe('Endpoint permissions:', () => {
let indexedData: IndexedHostsAndAlertsResponse;

before(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
);
};

describe.skip('Response Actions Responder', function () {
describe('Response Actions Responder', function () {
let indexedData: IndexedHostsAndAlertsResponse;
let endpointAgentId: string;

Expand Down

0 comments on commit d9d10f2

Please sign in to comment.