[ILM] Refactor types and fix missing aria labels (elastic#101518) (el…

…astic#101742)

* Refactor phase types (mostly moving imports)

* Refactor phase types (mostly moving imports)

* Renamed a type for consistency and replaced more hard coded strings with types

* Fixed remaining references to the deleted MinAgePhase

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/app/app.helpers.tsx

@@ -8,7 +8,7 @@
 import React from 'react';
 import { act } from 'react-dom/test-utils';
 import { registerTestBed, TestBed, TestBedConfig } from '@kbn/test/jest';
-import { KibanaContextProvider } from '../../../../../../src/plugins/kibana_react/public/context';
+import { KibanaContextProvider } from '../../../../../../src/plugins/kibana_react/public';
 import { createBreadcrumbsMock } from '../../../public/application/services/breadcrumbs.mock';
 import { licensingMock } from '../../../../licensing/public/mocks';
 import { App } from '../../../public/application/app';

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/app/app.test.ts

@@ -5,15 +5,17 @@
  * 2.0.
  */
 
+import { act } from 'react-dom/test-utils';
+
+import { getDefaultHotPhasePolicy, POLICY_NAME } from '../edit_policy/constants';
+import { setupEnvironment } from '../helpers';
+
 import {
   AppTestBed,
   getDoubleEncodedPolicyEditPath,
   getEncodedPolicyEditPath,
   setup,
 } from './app.helpers';
-import { setupEnvironment } from '../helpers/setup_environment';
-import { getDefaultHotPhasePolicy, POLICY_NAME } from '../edit_policy/constants';
-import { act } from 'react-dom/test-utils';
 
 const SPECIAL_CHARS_NAME = 'test?#$+=&@:';
 const PERCENT_SIGN_NAME = 'test%';

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx

@@ -8,8 +8,9 @@
 import { TestBedConfig } from '@kbn/test/jest';
 import { AppServicesContext } from '../../../public/types';
 
+import { Phase } from '../../../common/types';
+
 import {
-  Phase,
   createNodeAllocationActions,
   createFormToggleAction,
   createFormSetValueAction,
@@ -27,7 +28,6 @@ import {
   createReadonlyActions,
   createIndexPriorityActions,
 } from '../helpers';
-
 import { initTestBed } from './init_test_bed';
 
 type SetupReturn = ReturnType<typeof setup>;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/delete_phase.test.ts

@@ -5,16 +5,16 @@
  * 2.0.
  */
 
+import { act } from 'react-dom/test-utils';
+import { API_BASE_PATH } from '../../../../common/constants';
+import { setupEnvironment } from '../../helpers';
+import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 import {
   DELETE_PHASE_POLICY,
   getDefaultHotPhasePolicy,
   NEW_SNAPSHOT_POLICY_NAME,
   SNAPSHOT_POLICY_NAME,
 } from '../constants';
-import { act } from 'react-dom/test-utils';
-import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
-import { API_BASE_PATH } from '../../../../common/constants';
-import { setupEnvironment } from '../../helpers/setup_environment';
 
 describe('<EditPolicy /> delete phase', () => {
   let testBed: EditPolicyTestBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/frozen_phase.test.ts

@@ -8,7 +8,7 @@
 import { act } from 'react-dom/test-utils';
 
 import { licensingMock } from '../../../../../licensing/public/mocks';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> frozen phase', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/node_allocation/cloud_aware_behavior.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../../helpers/setup_environment';
+import { setupEnvironment } from '../../../helpers';
 import {
   CloudNodeAllocationTestBed,
   setupCloudNodeAllocation,

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/node_allocation/cold_phase.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../../helpers/setup_environment';
+import { setupEnvironment } from '../../../helpers';
 import { NodeAllocationTestBed, setupColdPhaseNodeAllocation } from './cold_phase.helpers';
 
 describe('<EditPolicy /> node allocation in the cold phase', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/node_allocation/general_behavior.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../../helpers/setup_environment';
+import { setupEnvironment } from '../../../helpers';
 import {
   GeneralNodeAllocationTestBed,
   setupGeneralNodeAllocation,

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/node_allocation/warm_phase.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../../helpers/setup_environment';
+import { setupEnvironment } from '../../../helpers';
 import { NodeAllocationTestBed, setupWarmPhaseNodeAllocation } from './warm_phase.helpers';
 
 describe('<EditPolicy /> node allocation in the warm phase', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/request_flyout.test.ts

@@ -6,8 +6,8 @@
  */
 
 import { act } from 'react-dom/test-utils';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
-import { setupEnvironment } from '../../helpers/setup_environment';
 
 describe('<EditPolicy /> request flyout', () => {
   let testBed: EditPolicyTestBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/rollover.test.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { licensingMock } from '../../../../../licensing/public/mocks';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> rollover', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/searchable_snapshots.test.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { licensingMock } from '../../../../../licensing/public/mocks';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { getDefaultHotPhasePolicy } from '../constants';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/timeline.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> timeline', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/features/warm_phase.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> warm phase', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/cold_phase_validation.test.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { i18nTexts } from '../../../../public/application/sections/edit_policy/i18n_texts';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> cold phase validation', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/error_indicators.test.ts

@@ -6,7 +6,7 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> error indicators', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/hot_phase_validation.test.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { i18nTexts } from '../../../../public/application/sections/edit_policy/i18n_texts';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> hot phase validation', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/policy_name_validation.test.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { i18nTexts } from '../../../../public/application/sections/edit_policy/i18n_texts';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 import { getGeneratedPolicies } from '../constants';
 

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/timing.test.ts

@@ -8,8 +8,9 @@
 import { act } from 'react-dom/test-utils';
 import { i18nTexts } from '../../../../public/application/sections/edit_policy/i18n_texts';
 
+import { PhaseWithTiming } from '../../../../common/types';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
-import { setupEnvironment } from '../../helpers/setup_environment';
 
 describe('<EditPolicy /> timing validation', () => {
   let testBed: EditPolicyTestBed;
@@ -69,12 +70,12 @@ describe('<EditPolicy /> timing validation', () => {
     ['warm', 'cold', 'delete', 'frozen'].forEach((phase: string) => {
       const { name, value, error } = testConfig;
       test(`${phase}: ${name}`, async () => {
-        await actions.togglePhase(phase as 'warm' | 'cold' | 'delete' | 'frozen');
+        await actions.togglePhase(phase as PhaseWithTiming);
         // 1. We first set as dummy value to have a starting min_age value
-        await actions[phase as 'warm' | 'cold' | 'delete' | 'frozen'].setMinAgeValue('111');
+        await actions[phase as PhaseWithTiming].setMinAgeValue('111');
         // 2. At this point we are sure there will be a change of value and that any validation
         // will be displayed under the field.
-        await actions[phase as 'warm' | 'cold' | 'delete' | 'frozen'].setMinAgeValue(value);
+        await actions[phase as PhaseWithTiming].setMinAgeValue(value);
 
         actions.errors.waitForValidation();
 

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/form_validation/warm_phase_validation.test.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { i18nTexts } from '../../../../public/application/sections/edit_policy/i18n_texts';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { setupEnvironment } from '../../helpers';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
 
 describe('<EditPolicy /> warm phase validation', () => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts

@@ -6,14 +6,14 @@
  */
 
 import { act } from 'react-dom/test-utils';
-import { setupEnvironment } from '../../helpers/setup_environment';
+import { licensingMock } from '../../../../../licensing/public/mocks';
+import { setupEnvironment } from '../../helpers';
 import {
   getDefaultHotPhasePolicy,
   POLICY_WITH_INCLUDE_EXCLUDE,
   POLICY_WITH_KNOWN_AND_UNKNOWN_FIELDS,
 } from '../constants';
 import { EditPolicyTestBed, setup } from '../edit_policy.helpers';
-import { licensingMock } from '../../../../../licensing/public/mocks';
 
 describe('<EditPolicy /> serialization', () => {
   let testBed: EditPolicyTestBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/errors_actions.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { TestBed } from '@kbn/test/jest';
-import { Phase } from '../types';
+import { Phase } from '../../../../common/types';
 
 const createWaitForValidationAction = (testBed: TestBed) => () => {
   const { component } = testBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/forcemerge_actions.ts

@@ -7,9 +7,9 @@
 
 import { act } from 'react-dom/test-utils';
 import { TestBed } from '@kbn/test/jest';
+import { Phase } from '../../../../common/types';
 import { createFormToggleAction } from './form_toggle_action';
 import { createFormSetValueAction } from './form_set_value_action';
-import { Phase } from '../types';
 
 const createFormCheckboxAction = (testBed: TestBed, dataTestSubject: string) => async (
   checked: boolean

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/freeze_actions.ts

@@ -6,8 +6,8 @@
  */
 
 import { TestBed } from '@kbn/test/jest';
+import { Phase } from '../../../../common/types';
 import { createFormToggleAction } from './form_toggle_action';
-import { Phase } from '../types';
 
 export const createFreezeActions = (testBed: TestBed, phase: Phase) => {
   const { exists } = testBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/index_priority_actions.ts

@@ -6,9 +6,9 @@
  */
 
 import { TestBed } from '@kbn/test/jest';
+import { Phase } from '../../../../common/types';
 import { createFormToggleAction } from './form_toggle_action';
 import { createFormSetValueAction } from './form_set_value_action';
-import { Phase } from '../types';
 
 export const createIndexPriorityActions = (testBed: TestBed, phase: Phase) => {
   const { exists } = testBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/min_age_actions.ts

@@ -6,8 +6,8 @@
  */
 
 import { TestBed } from '@kbn/test/jest';
+import { Phase } from '../../../../common/types';
 import { createFormSetValueAction } from './form_set_value_action';
-import { Phase } from '../types';
 
 export const createMinAgeActions = (testBed: TestBed, phase: Phase) => {
   const { exists } = testBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/node_allocation_actions.ts

@@ -9,7 +9,7 @@ import { act } from 'react-dom/test-utils';
 import { TestBed } from '@kbn/test/jest';
 
 import { DataTierAllocationType } from '../../../../public/application/sections/edit_policy/types';
-import { Phase } from '../types';
+import { Phase } from '../../../../common/types';
 import { createFormSetValueAction } from './form_set_value_action';
 
 export const createNodeAllocationActions = (testBed: TestBed, phase: Phase) => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/readonly_actions.ts

@@ -6,8 +6,8 @@
  */
 
 import { TestBed } from '@kbn/test/jest';
+import { Phase } from '../../../../common/types';
 import { createFormToggleAction } from './form_toggle_action';
-import { Phase } from '../types';
 
 export const createReadonlyActions = (testBed: TestBed, phase: Phase) => {
   const { exists } = testBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/searchable_snapshot_actions.ts

@@ -7,7 +7,7 @@
 
 import { act } from 'react-dom/test-utils';
 import { TestBed } from '@kbn/test/jest';
-import { Phase } from '../types';
+import { Phase } from '../../../../common/types';
 import { createFormToggleAction } from './form_toggle_action';
 
 export const createSearchableSnapshotActions = (testBed: TestBed, phase: Phase) => {

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/set_replicas_action.ts

@@ -7,7 +7,7 @@
 
 import { TestBed } from '@kbn/test/jest';
 
-import { Phase } from '../types';
+import { Phase } from '../../../../common/types';
 import { createFormToggleAction } from './form_toggle_action';
 import { createFormSetValueAction } from './form_set_value_action';
 

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/shrink_actions.ts

@@ -6,9 +6,9 @@
  */
 
 import { TestBed } from '@kbn/test/jest';
+import { Phase } from '../../../../common/types';
 import { createFormToggleAction } from './form_toggle_action';
 import { createFormSetValueAction } from './form_set_value_action';
-import { Phase } from '../types';
 
 export const createShrinkActions = (testBed: TestBed, phase: Phase) => {
   const { exists } = testBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/actions/toggle_phase_action.ts

@@ -6,9 +6,9 @@
  */
 
 import { TestBed } from '@kbn/test/jest';
-
 import { act } from 'react-dom/test-utils';
-import { Phase } from '../types';
+
+import { Phase } from '../../../../common/types';
 
 const toggleDeletePhase = async (testBed: TestBed) => {
   const { find, component } = testBed;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/index.ts

@@ -5,6 +5,6 @@
  * 2.0.
  */
 
-export { Phase } from './types';
-
 export * from './actions';
+
+export { setupEnvironment } from './setup_environment';