[Security Solution][Investigations] - Update timeline host and ip fie…

…lds to be clickable (elastic#117403) (elastic#117481) Co-authored-by: Michael Olorunnisola <[email protected]>
kibanamachine · Nov 4, 2021 · ad09075 · ad09075
1 parent 87186d3
commit ad09075
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/..._solution/public/timelines/components/timeline/body/data_driven_columns/stateful_cell.tsx b/..._solution/public/timelines/components/timeline/body/data_driven_columns/stateful_cell.tsx
@@ -51,6 +51,7 @@ const StatefulCellComponent = ({
         isExpandable: true,
         isExpanded: false,
         isDetails: false,
+        isTimeline: true,
         linkValues,
         rowIndex: ariaRowindex - 1,
         setCellProps,

diff --git a/...ty_solution/public/timelines/components/timeline/cell_rendering/default_cell_renderer.tsx b/...ty_solution/public/timelines/components/timeline/cell_rendering/default_cell_renderer.tsx
@@ -32,6 +32,7 @@ export const DefaultCellRenderer: React.FC<CellValueElementProps> = ({
   header,
   isDetails,
   isDraggable,
+  isTimeline,
   linkValues,
   rowRenderers,
   setCellProps,
@@ -49,7 +50,7 @@ export const DefaultCellRenderer: React.FC<CellValueElementProps> = ({
     <>
       <StyledContent className={styledContentClassName} $isDetails={isDetails}>
         {getColumnRenderer(header.id, columnRenderers, data).renderColumn({
-          asPlainText: !!getLink(header.id, header.type), // we want to render value with links as plain text but keep other formatters like badge.
+          asPlainText: !!getLink(header.id, header.type) && !isTimeline, // we want to render value with links as plain text but keep other formatters like badge.
           browserFields,
           columnName: header.id,
           ecsData,

diff --git a/x-pack/plugins/timelines/common/types/timeline/cells/index.ts b/x-pack/plugins/timelines/common/types/timeline/cells/index.ts
@@ -23,6 +23,7 @@ export type CellValueElementProps = EuiDataGridCellValueElementProps & {
   globalFilters?: Filter[];
   header: ColumnHeaderOptions;
   isDraggable: boolean;
+  isTimeline?: boolean; // Default cell renderer is used for both the alert table and timeline. This allows us to cheaply separate concerns
   linkValues: string[] | undefined;
   rowRenderers?: RowRenderer[];
   // eslint-disable-next-line @typescript-eslint/no-explicit-any