forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for GeoIP processor databases in Ingest Pipelines (elasti…
…c#190830) Fixes elastic#190818 ## Summary Elasticsearch has added support for GeoIP, enabling the use of paid GeoIP databases from MaxMind/IPInfo for more accurate and granular geolocation data. As such we should add support to ingest pipelines UI for making this available to the user. * If the user doesn't have enough privileges, the "Manage Pipelines" link and UI won't show. * Users can add two types of databases through the UI: MaxMind and IPinfo. Database names are predefined by ES, and the user cannot enter their own. * Certain types of databases (local and web) can be configured through ES, and these will appear in the UI, but they cannot be deleted as they are read-only. * When configuring a `IP location` processor, the database field will display a list of available and configured databases that the user can select. It also allows for free-text input if the user wants to configure a database that does not yet exist. * The new IP location processor is essentially a clone of the GeoIP processor, which we are moving away from due to copyright issues. However, it was decided that GeoIP will remain as is for backward compatibility, and all new work will only be added to IP location going forward. * I left a few mocks in the `server/routes/api/geoip_database/list.ts ` to try `local/web` types ## Release note The Ingest Pipelines app now supports adding and managing databases for the GeoIP processor. Additionally, the pipeline creation flow now includes support for the IP Location processor. <details> <summary>Screenshots</summary>       </details> --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Elena Stoeva <[email protected]> Co-authored-by: Elena Stoeva <[email protected]> Co-authored-by: Matthew Kime <[email protected]> (cherry picked from commit 302ac0d)
- Loading branch information
Showing
54 changed files
with
2,218 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
...plugins/ingest_pipelines/__jest__/client_integration/helpers/manage_processors.helpers.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { act } from 'react-dom/test-utils'; | ||
| import { HttpSetup } from '@kbn/core/public'; | ||
|
|
||
| import { registerTestBed, TestBed, AsyncTestBedConfig } from '@kbn/test-jest-helpers'; | ||
| import { ManageProcessors } from '../../../public/application/sections'; | ||
| import { WithAppDependencies } from './setup_environment'; | ||
| import { getManageProcessorsPath, ROUTES } from '../../../public/application/services/navigation'; | ||
|
|
||
| const testBedConfig: AsyncTestBedConfig = { | ||
| memoryRouter: { | ||
| initialEntries: [getManageProcessorsPath()], | ||
| componentRoutePath: ROUTES.manageProcessors, | ||
| }, | ||
| doMountAsync: true, | ||
| }; | ||
|
|
||
| export type ManageProcessorsTestBed = TestBed<ManageProcessorsTestSubjects> & { | ||
| actions: ReturnType<typeof createActions>; | ||
| }; | ||
|
|
||
| const createActions = (testBed: TestBed) => { | ||
| const { component, find, form } = testBed; | ||
|
|
||
| const clickDeleteDatabaseButton = async (index: number) => { | ||
| const allDeleteButtons = find('deleteGeoipDatabaseButton'); | ||
| const deleteButton = allDeleteButtons.at(index); | ||
| await act(async () => { | ||
| deleteButton.simulate('click'); | ||
| }); | ||
|
|
||
| component.update(); | ||
| }; | ||
|
|
||
| const confirmDeletingDatabase = async () => { | ||
| await act(async () => { | ||
| form.setInputValue('geoipDatabaseConfirmation', 'delete'); | ||
| }); | ||
|
|
||
| component.update(); | ||
|
|
||
| const confirmButton: HTMLButtonElement | null = document.body.querySelector( | ||
| '[data-test-subj="deleteGeoipDatabaseSubmit"]' | ||
| ); | ||
|
|
||
| expect(confirmButton).not.toBe(null); | ||
| expect(confirmButton!.disabled).toBe(false); | ||
| expect(confirmButton!.textContent).toContain('Delete'); | ||
|
|
||
| await act(async () => { | ||
| confirmButton!.click(); | ||
| }); | ||
|
|
||
| component.update(); | ||
| }; | ||
|
|
||
| const clickAddDatabaseButton = async () => { | ||
| const button = find('addGeoipDatabaseButton'); | ||
| expect(button).not.toBe(undefined); | ||
| await act(async () => { | ||
| button.simulate('click'); | ||
| }); | ||
|
|
||
| component.update(); | ||
| }; | ||
|
|
||
| const fillOutDatabaseValues = async ( | ||
| databaseType: string, | ||
| databaseName: string, | ||
| maxmind?: string | ||
| ) => { | ||
| await act(async () => { | ||
| form.setSelectValue('databaseTypeSelect', databaseType); | ||
| }); | ||
| component.update(); | ||
|
|
||
| if (maxmind) { | ||
| await act(async () => { | ||
| form.setInputValue('maxmindField', maxmind); | ||
| }); | ||
| } | ||
| await act(async () => { | ||
| form.setSelectValue('databaseNameSelect', databaseName); | ||
| }); | ||
|
|
||
| component.update(); | ||
| }; | ||
|
|
||
| const confirmAddingDatabase = async () => { | ||
| const confirmButton: HTMLButtonElement | null = document.body.querySelector( | ||
| '[data-test-subj="addGeoipDatabaseSubmit"]' | ||
| ); | ||
|
|
||
| expect(confirmButton).not.toBe(null); | ||
| expect(confirmButton!.disabled).toBe(false); | ||
|
|
||
| await act(async () => { | ||
| confirmButton!.click(); | ||
| }); | ||
|
|
||
| component.update(); | ||
| }; | ||
|
|
||
| return { | ||
| clickDeleteDatabaseButton, | ||
| confirmDeletingDatabase, | ||
| clickAddDatabaseButton, | ||
| fillOutDatabaseValues, | ||
| confirmAddingDatabase, | ||
| }; | ||
| }; | ||
|
|
||
| export const setup = async (httpSetup: HttpSetup): Promise<ManageProcessorsTestBed> => { | ||
| const initTestBed = registerTestBed( | ||
| WithAppDependencies(ManageProcessors, httpSetup), | ||
| testBedConfig | ||
| ); | ||
| const testBed = await initTestBed(); | ||
|
|
||
| return { | ||
| ...testBed, | ||
| actions: createActions(testBed), | ||
| }; | ||
| }; | ||
|
|
||
| export type ManageProcessorsTestSubjects = | ||
| | 'manageProcessorsTitle' | ||
| | 'addGeoipDatabaseForm' | ||
| | 'addGeoipDatabaseButton' | ||
| | 'geoipDatabaseList' | ||
| | 'databaseTypeSelect' | ||
| | 'maxmindField' | ||
| | 'databaseNameSelect' | ||
| | 'addGeoipDatabaseSubmit' | ||
| | 'deleteGeoipDatabaseButton' | ||
| | 'geoipDatabaseConfirmation' | ||
| | 'geoipEmptyListPrompt' | ||
| | 'geoipListLoadingError'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.