Skip to content

Commit

Permalink
[Security Solution] adds missing dependency fieldFormats in kibana.…
Browse files Browse the repository at this point in the history
…jsonc (elastic#160445)

## Summary

Adds missing dependency from this PR:
elastic#158594
  • Loading branch information
dhurley14 authored Jun 23, 2023
1 parent e7b0389 commit 1ee60b0
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
12 changes: 4 additions & 8 deletions x-pack/plugins/security_solution/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
"id": "securitySolution",
"server": true,
"browser": true,
"configPath": [
"xpack",
"securitySolution"
],
"configPath": ["xpack", "securitySolution"],
"requiredPlugins": [
"actions",
"alerting",
Expand All @@ -25,6 +22,7 @@
"embeddable",
"eventLog",
"features",
"fieldFormats",
"guidedOnboarding",
"inspector",
"kubernetesSecurity",
Expand All @@ -43,7 +41,7 @@
"files",
"controls",
"savedObjectsManagement",
"stackConnectors",
"stackConnectors"
],
"optionalPlugins": [
"cloudExperiments",
Expand Down Expand Up @@ -71,8 +69,6 @@
"unifiedSearch",
"cloudChat"
],
"extraPublicDirs": [
"common"
]
"extraPublicDirs": ["common"]
}
}
9 changes: 9 additions & 0 deletions x-pack/plugins/security_solution/public/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ export interface SetupPlugins {
ml?: MlPluginSetup;
}

/**
* IMPORTANT - PLEASE READ: When adding new plugins to the
* security solution, please ensure you add that plugin
* name to the kibana.jsonc file located in ../kibana.jsonc
*
* Without adding the plugin name there, the plugin will not
* fulfill at runtime, despite the types showing up correctly
* in the code.
*/
export interface StartPlugins {
cases: CasesUiStart;
data: DataPublicPluginStart;
Expand Down

0 comments on commit 1ee60b0

Please sign in to comment.