[Telemetry] Permanently hide the telemetry notice on dismissal (elast…

…ic#159893)
kibanamachine · Jun 19, 2023 · 14c5fff · 14c5fff
1 parent 9fc9947
commit 14c5fff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/plugins/telemetry/server/routes/index.ts b/src/plugins/telemetry/server/routes/index.ts
@@ -35,6 +35,6 @@ export function registerRoutes(options: RegisterRoutesParams) {
   registerTelemetryConfigRoutes(options);
   registerTelemetryUsageStatsRoutes(router, telemetryCollectionManager, isDev, getSecurity);
   registerTelemetryOptInStatsRoutes(router, telemetryCollectionManager);
-  registerTelemetryUserHasSeenNotice(router);
+  registerTelemetryUserHasSeenNotice(router, options.currentKibanaVersion);
   registerTelemetryLastReported(router, savedObjectsInternalClient$);
 }
diff --git a/src/plugins/telemetry/server/routes/telemetry_user_has_seen_notice.ts b/src/plugins/telemetry/server/routes/telemetry_user_has_seen_notice.ts
@@ -15,7 +15,7 @@ import {
   updateTelemetrySavedObject,
 } from '../saved_objects';
 
-export function registerTelemetryUserHasSeenNotice(router: IRouter) {
+export function registerTelemetryUserHasSeenNotice(router: IRouter, currentKibanaVersion: string) {
   router.put(
     {
       path: '/api/telemetry/v2/userHasSeenNotice',
@@ -31,6 +31,9 @@ export function registerTelemetryUserHasSeenNotice(router: IRouter) {
       const updatedAttributes: TelemetrySavedObjectAttributes = {
         ...telemetrySavedObject,
         userHasSeenNotice: true,
+        // We need to store that the user was notified in this version.
+        // Otherwise, it'll continuously show the banner if previously opted-out.
+        lastVersionChecked: currentKibanaVersion,
       };
       await updateTelemetrySavedObject(soClient, updatedAttributes);