-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pm 46209 plugin review #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! Just a few minor things I commented on.
Also, no idea why the CI suddenly broke. But that happened before your commits. I'll investigate.
Looks like it's a problem upstream in the moodle setup code we use: moodlehq/moodle-plugin-ci#309 |
Merging this into our story branch |
No description provided.