Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metal/dhcp): use IP lease range based on network CIDR #41

Merged
merged 1 commit into from
Feb 13, 2022
Merged

fix(metal/dhcp): use IP lease range based on network CIDR #41

merged 1 commit into from
Feb 13, 2022

Conversation

linhng98
Copy link
Contributor

@linhng98 linhng98 commented Feb 13, 2022

BUG: sometime, the default gateway ip is not always .1, thus not stable to use as lease ip range for dhcp.
For example: if your default gaateway IP is 192.168.1.253, then your dhcp lease range is 192.168.1.254-192.168.1.254, and the pxe boot process won't work

@khuedoan khuedoan changed the title fix: use ip lease range based on network cidr fix(metal/dhcp): use IP lease range based on network CIDR Feb 13, 2022
Copy link
Owner

@khuedoan khuedoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

LGTM

@khuedoan khuedoan merged commit d10892a into khuedoan:master Feb 13, 2022
zanehala added a commit to zanehala/homelab that referenced this pull request Mar 16, 2023
retX0 pushed a commit to retX0/homelab that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants