Add API for tracking checked to the inner_size of a window #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matched the apis used for focused and occluded properties. I've added an example to demonstrate usage.
|
We need to also let the user update the value stored in the dynamic, that way the programmer can dynamically set the window size in addition to read it. If we want a read-only interface, this should be exposed as a DynamicReader instead. The resize logic is really tricky (see #92), however, so I'm going to volunteer to tackle that unless you're feeling ambitious! The changes look great! |
ecton
added a commit
that referenced
this pull request
Dec 19, 2023
This adds upon the work in #94 by allowing the dynamic's value to be set and it cause the window size to change. I've ordered the resizing operations so that changes to the property are prioritized over automatic adjustments. This doesn't change the behavior for automatic adjustments in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matched the apis used for focused and occluded properties. I've added an example to demonstrate usage.
Closes #61