Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hardcoded nightly version #46

Closed
ecton opened this issue Apr 21, 2021 · 2 comments
Closed

Revert hardcoded nightly version #46

ecton opened this issue Apr 21, 2021 · 2 comments
Labels
blocked This issue can't be resolved due to a dependency

Comments

@ecton
Copy link
Member

ecton commented Apr 21, 2021

Code coverage started failing recently, and it appears that it's due to an ICE that dates back a little bit, but only recently started cropping up most likely due to rustfmt being broken on nightly for a while: GitHub issue/pull request detail. I tried to narrow it down, but I can't seem to get the ICE to occur outside of the project.

The earliest version of nightly that installed all the default components that doesn't cause an ICE is 2021-03-25.

The commit to revert is: cd668bf

ecton added a commit that referenced this issue Apr 21, 2021
@ecton ecton added the blocked This issue can't be resolved due to a dependency label Apr 21, 2021
@richkadel
Copy link

richkadel commented Apr 23, 2021

There was a recent change that landed in nightly just a couple of days ago that started causing an ICE for certain macro invocations. I suspect this is the issue you noticed.

I've submitted a pull request to fix it: rust-lang/rust#84456

It's approved and should be in nightly in a couple of days or so.

@ecton
Copy link
Member Author

ecton commented Apr 23, 2021

Thanks for the update, I can confirm that what I was whittling down seemed related to macros. And, more importantly, thank you for contributing a fix!

@ecton ecton closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue can't be resolved due to a dependency
Projects
None yet
Development

No branches or pull requests

2 participants