Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Captive portal #24

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Conversation

hmueller01
Copy link
Contributor

added feature captive portal

@khoih-prog
Copy link
Owner

Sorry for the delay as I'm busy with something else new and more interesting.

Merged now.

@khoih-prog khoih-prog merged commit 5560492 into khoih-prog:main Jan 10, 2023
khoih-prog added a commit that referenced this pull request Jan 10, 2023
### Release v1.10.0

1. Add  feature. Check [Captive portal #24](#24)
2. Add option to not `USE_LED_BUILTIN` for Config-Portal. Check [added switch to turn use of builtin LED off #20](#20)
3. Code clean-up
khoih-prog added a commit that referenced this pull request Jan 10, 2023
### Release v1.10.0

1. Add Captive-Portal feature. Check [Captive portal #24](#24)
2. Add option to not `USE_LED_BUILTIN` for Config-Portal. Check [added switch to turn use of builtin LED off #20](#20)
3. Code clean-up
@khoih-prog
Copy link
Owner

Hi @hmueller01

The new ESP_WiFiManager_Lite releases v1.10.0 has just been published. Your contribution is noted in Contributions and Thanks

Best Regards,


Release v1.10.0

  1. Add Captive-Portal feature. Check Captive portal #24
  2. Add option to not USE_LED_BUILTIN for Config-Portal. Check added switch to turn use of builtin LED off #20
  3. Code clean-up

@hmueller01
Copy link
Contributor Author

Hey @khoih-prog, thanks for merging! Just a small note. Why did you use version 1.10.0 here and 1.9.1 at ESPAsync_WiFiManager_Lite? Shouldn't stay this the same?

@khoih-prog
Copy link
Owner

They are sync'ed @ v1.10.1 now. Thanks for the note.

@khoih-prog khoih-prog mentioned this pull request Jan 15, 2023
@hmueller01 hmueller01 deleted the Captive_Portal branch March 16, 2023 19:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants