Changed test to verify handling of readonly lists

khellang · Jan 4, 2015 · 619a282 · 619a282
1 parent 9e2bfb6
commit 619a282
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 16 deletions.
diff --git a/Octokit.Tests.Integration/Clients/CommitStatusClientTests.cs b/Octokit.Tests.Integration/Clients/CommitStatusClientTests.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Linq;
 using System.Threading.Tasks;
 using Octokit;
 using Octokit.Tests.Integration;
@@ -30,19 +31,17 @@ public class TheGetCombinedMethod
         [IntegrationTest]
         public async Task CanRetrieveCombinedStatus()
         {
-            var githubClient = new GitHubClient(new ProductHeaderValue("OctokitTests"))
-            {
-                Credentials = Helper.Credentials
-            };
+            var githubClient = Helper.GetAuthenticatedClient();
             var status = await githubClient.Repository.CommitStatus.GetCombined(
-            "rails",
-            "rails",
-            "94b857899506612956bb542e28e292308accb908");
-            Assert.Equal(CommitState.Failure, status.State);
-            Assert.Equal("94b857899506612956bb542e28e292308accb908", status.Sha);
-            Assert.Equal(1, status.TotalCount);
-            Assert.Equal(CommitState.Failure, status.Statuses[0].State);
-            Assert.Equal("The Travis CI build failed", status.Statuses[0].Description);
+            "libgit2",
+            "libgit2sharp",
+            "f54529997b6ad841be524654d9e9074ab8e7d41d");
+            Assert.Equal(CommitState.Success, status.State);
+            Assert.Equal("f54529997b6ad841be524654d9e9074ab8e7d41d", status.Sha);
+            Assert.Equal(2, status.TotalCount);
+            Assert.Equal(2, status.Statuses.Count);
+            Assert.True(status.Statuses.All(x => x.State == CommitState.Success));
+            Assert.Equal("The Travis CI build passed", status.Statuses[0].Description);
         }
     }
 

diff --git a/Octokit/Models/Response/CombinedCommitStatus.cs b/Octokit/Models/Response/CombinedCommitStatus.cs
@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 
 namespace Octokit
@@ -26,9 +25,7 @@ public class CombinedCommitStatus
         /// <summary>
         /// The statuses.
         /// </summary>
-        // TODO: This ought to be an IReadOnlyList<ApiErrorDetail> but we need to add support to SimpleJson for that.
-        [SuppressMessage("Microsoft.Usage", "CA2227:CollectionPropertiesShouldBeReadOnly")]
-        public IList<CommitStatus> Statuses { get; protected set; }
+        public IReadOnlyList<CommitStatus> Statuses { get; protected set; }
 
         /// <summary>
         /// The repository of the reference.