Work around type load errors in .NET Framework

khellang · Sep 26, 2024 · face8c7 · face8c7
1 parent d7f676e
commit face8c7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/Scrutor/ReflectionExtensions.cs b/src/Scrutor/ReflectionExtensions.cs
@@ -218,6 +218,23 @@ private static bool GenericParametersMatch(IReadOnlyList<Type> parameters, IRead
         return true;
     }
 
+    // Workaround for type load issues in .NET Framework
+    public static IReadOnlyCollection<Type> GetLoadableTypes(this Assembly assembly)
+    {
+        try
+        {
+            return assembly.GetTypes();
+        }
+        catch (ReflectionTypeLoadException ex)
+        {
+            return ex.Types.Where(t => t is not null).ToArray()!;
+        }
+        catch
+        {
+            return [];
+        }
+    }
+
     public static string ToFriendlyName(this Type type)
     {
         return TypeNameHelper.GetTypeDisplayName(type, includeGenericParameterNames: true);

diff --git a/src/Scrutor/TypeSourceSelector.cs b/src/Scrutor/TypeSourceSelector.cs
@@ -42,7 +42,7 @@ public IImplementationTypeSelector FromCallingAssembly()
     {
         return FromAssemblies(Assembly.GetCallingAssembly());
     }
-    
+
     /// <summary>
     /// Always uses the Scrutor assembly.
     /// </summary>
@@ -188,7 +188,7 @@ private IImplementationTypeSelector InternalFromAssembliesOf(IEnumerable<Type> t
 
     private IImplementationTypeSelector InternalFromAssemblies(IEnumerable<Assembly> assemblies)
     {
-        return AddSelector(assemblies.SelectMany(asm => asm.GetTypes()));
+        return AddSelector(assemblies.SelectMany(asm => asm.GetLoadableTypes()));
     }
 
     private static ISet<Assembly> LoadAssemblies(ISet<AssemblyName> assemblyNames)