Use the correct jq package

[rougetimelord]

jq package is a jQuery wrapper, and we don't use commander at all.

node-jq allows us to use jq inside of node files, and as a side benefit it downloads the jq binary to ./node_modules/node-jq/bin/jq. So we could update the makefile to use that binary, or alternatively turn the functionality of the makefile into a node script?

[cooljeanius]

jq package is a jQuery wrapper, and we don't use commander at all.

node-jq allows us to use jq inside of node files, and as a side benefit it downloads the jq binary to ./node_modules/node-jq/bin/jq. So we could update the makefile to use that binary, or alternatively turn the functionality of the makefile into a node script?

Personally I know Makefiles better than I know node, so I'd prefer to keep it as a Makefile instead of turning it into a node script...

[rougetimelord]

Personally I know Makefiles better than I know node, so I'd prefer to keep it as a Makefile instead of turning it into a node script...

Would you be willing to change the makefile so that it uses the downloaded binary?

[cooljeanius]

Personally I know Makefiles better than I know node, so I'd prefer to keep it as a Makefile instead of turning it into a node script...

Would you be willing to change the makefile so that it uses the downloaded binary?

Well... hm. I know how I'd do this if we were generating the makefile with autotools, but since we're not... I guess PATH modification can be hardcoded directly into the makefile; let me check...

[cooljeanius]

Personally I know Makefiles better than I know node, so I'd prefer to keep it as a Makefile instead of turning it into a node script...

Would you be willing to change the makefile so that it uses the downloaded binary?

Well... hm. I know how I'd do this if we were generating the makefile with autotools, but since we're not... I guess PATH modification can be hardcoded directly into the makefile; let me check...

@rougetimelord do you want me to do this as part of this PR, or a separate one?

[rougetimelord]

@rougetimelord do you want me to do this as part of this PR, or a separate one?

Yeah let's do it in here

[cooljeanius]

Could you give f7c8ebb a try? I'm not quite sure if I did it the right way, or if I need to add an extra $, or put it inside $(shell ...), or add export, or something...

[cooljeanius]

Could you give f7c8ebb a try? Not quite sure if I did it the right way, or need to add an extra $, or put it inside $(shell ...), or add export, or something...

Ah wait nvm, CI caught it...

[cooljeanius]

OK try now after 2427a42?

[rougetimelord]

I don't have a lot of knowledge around make, does it work locally for you?

[cooljeanius]

I don't have a lot of knowledge around make, does it work locally for you?

I mean, I have jq installed globally, so that would just get picked up first anyways either way...