0.4.2 #267
0.4.2 #267
Conversation
Need some diff to start an LLB PR
rougetimelord
requested review from
kheina,
jaredcat,
MrAwesome and
cooljeanius
as code owners
I did an oopsie whoopsie and flipped the logic in my brain!!
With the new integrations system I want to document everything that gets sent over so other extension devs can implement their own checks that use data that we don't.
Idk what happened here? Did I write code past my bed time? Maybe, no one can ever truly know
[fix] remove reference to chrome.runtime.restartAfterDelay
… as an integration External extensions can now send a request to Blue Blocker to be registered as a new integration. New integrations registered in this way are set to the disabled state by default, and the user of Blue Block still has to manually set the permissions of the new integration in order for the integration functionality to be enabled. This feature just makes it so that extension users do not have to find the extension ID of an external extension to register an integration.
…rompt [feat] integration registration prompt
explain 'i' Reapply "case insensitive" This reverts commit ae0aa51. Revert "case insensitive" This reverts commit 2272caa. case insensitive Update index.ts Update index.html Update shared.ts Stylizing changes, refactor element name, add status element [Fix[ Unclosed textarea tag that caused safelist and integrations buttons to not render Add a warning to the option explanation Change to a better console log string Use input number rules for textarea Should make the textarea look more cohesive with the rest of the UI [Fix] Typo Refactor disallowed words update func, remove uneeded error logging, strip whitespace before storing Update shared.ts remove unused function
Switch Firefox Workflow Action
The array.join method does not add the separator to the end of the last array entry, but we need the lookahead on each entry to make sure we don't match on fragments inside of a word
|
Going to start testing! Can confirm that with the fixes the extension can queue and block people again |
|
Problems:
|
I added this check specifically to address this issue in my original PR. |
Yea, but then we switched to precompiling the regex, so I'll futz around with it |
|
Ok that's all the bugs I've found so far squashed. Going to keep testing for tonight to see if something pops up, but I think we're close to being able to merge. |
|
I'll do another review and some testing tonight after work. hopefully it can go out tonight |
I'll probably also just push a bunch of styling changes/fixes since I'm pretty particular about the appearance of the popup menu |
Go ham! I think having the setting be hidden behind a checkbox if not enabled would make a lot of sense in terms of not cluttering up the interface, kinda like what the skip threshold setting does |
I went ham |
…es people when skip blue is enabled
| if (user.legacy?.blocking || (config.mute && user.legacy?.muting)) { | ||
| return; | ||
| } | ||
| // set up this funky little function so that we can return to exit early from verified block but continue with other steps |
There was a problem hiding this comment.
I like this, might be worth splitting this function out in the future
|
One approval pls 👉🏻👈🏻 |
This is a long-lived branch, intended to aggregate all changes planned for version
0.4.2.Pull requests should be made against this branch. Merges to this branch should be done via a merge commit. When ready, this branch should be merged to main via a squash commit.
Changelog
Deployment Checklist
src/manifest.tsandpackage.jsonhave the correct version numbermake chrome,make firefox)npm run build