Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate bumping manifest version #264

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Automate bumping manifest version #264

merged 1 commit into from
Apr 17, 2024

Conversation

rougetimelord
Copy link
Collaborator

Just run npm version, it's that easy! A 144444.99 dollar value that you get for the low low price of me losing my mind looking at npm man pages

Changelog

  • Add a version script that gets run when npm version runs
    • That shit looks so ugly, i'm sooooo sorry. I didn't want to add a new file just for a goofy code chore
  • Add config to package.json
    • I set it so it won't make commits with the message "v", that would be really annoying! It's also set so that we don't have a spam of tags that get fucky after squash and merges

@rougetimelord
Automate bumping manifest version
1a64c9e 
Just run npm version, it's that easy! A 144444.99 dollar value that you get for the low low price of me losing my mind looking at npm man pages
cooljeanius
cooljeanius approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this is allowed? OK, I guess...

@rougetimelord
Copy link
Collaborator Author

Huh, this is allowed? OK, I guess...

It just looks messed up, I swear it works

@rougetimelord rougetimelord merged commit 7fe5735 into main Apr 17, 2024
4 checks passed
@rougetimelord rougetimelord deleted the version-script branch April 17, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooljeanius cooljeanius cooljeanius approved these changes

@kheina kheina Awaiting requested review from kheina kheina is a code owner

@jaredcat jaredcat Awaiting requested review from jaredcat jaredcat is a code owner

@MrAwesome MrAwesome Awaiting requested review from MrAwesome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rougetimelord @cooljeanius