Update from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the class docker::services already allowed arrays to be
specified for `publish` ports, it didn't handle this correctly since
this array was simply converted to a string and passed onto Docker,
like so:
--publish '["80:80", "443:443"]'
To correctly publish multiple ports, the `--publish` parameter has to
be called specified for each port.
--publish '80:80' --publish '443:443'
This patch also introduces a new spec test to check this behavior
Allows attaching the service to one or multiple networks
The module previously allowed specifying the command parameter to docker::services as an array, but did not correctly parse it as such (output with square brackets and quotations marks to docker). This patch fixes this behavior.
* wip: updated README to include aws logging option details added in pull request #354 * wip: corrected formatting * wip: corrected formatting
Restore the code to update images tagged with 'latest' on each run, moving this to be guarded by a refreshonly meta-parameter that is triggered by a notify resource that is disabled for 'noop'. Because the original code to update images was run via 'onlyif' to indicate if the image was in sync by performing a pull and testing the new digest against the old, this meant that simply applying 'noop' to this exec resource would not work. 'noop' does not affect running the components of a resource to validate if it is in-sync, which is the purpose of the 'onlyif' & 'unless' settings for an exec. To support 'noop' mode, previously the code to update the image on each run was dropped to prevent it accidentally refreshing the local image and then skipping an image restart because there was no update event on a subsequent real run. To resolve, it is necessary to have a prior resource that is used as a proxy, and only when it notifies the image update resource, will the 'onlyif' action be tested to determine if in sync. This prior resource can be disabled from a noop run, and subsequently although puppet records that it would send a refresh event in 'noop' mode, none are actually sent during a 'noop' run thus preventing the image from being updated by a side effect of checking if the notified exec was in-sync. Fixes #316
Fix test cases, class and readme Removed travis customisation
Fix container running check to work for windows hosts
Fix supported operating systems in the readme
Allow images tagged latest to update on each run
This module already has the code to support all systemd-based distributions, yet it is artificially locked to just Red Hat and Ubuntu/Debian. By exposing the `service_provider` parameter in the `docker::run` defined type (a parameter that is also exposed in the main `docker` class), this module becomes usable on most other distributions. Other minor fixes have been added to set missing variables when running under a non-Debian or non-RedHat operating system.
Add service_provider parameter to docker::run
The documentation of * docker_volume type * docker::volumes puppet class in README.md seems to be outdated and incorrect. This tries to fix the docs and adds an example for using an NFS volume.
Update docker volume documentation
While fixing the tests I uncovered that the docker_stack provider does not check for the existence of stacks properly on Windows. This appears to be due to it looking for containers tagged with latest, as not having any tag. As a result, the stack is created on every run and also cannot be destroyed. The changes here help rectify this however there is probably a better solution needed.
(MODULES-9033) Fix failing acceptance tests on all platforms
After having made changes to get Windows tests working with Server 2016, the image we changed to "winamd64/hello-world" has removed support for Server 2016. As such I have changed occurances of it to "winamd64/hello-seattle" which still has support.
(MODULES-9029) Update pdk-template to 46a1deb
(FM-8100) Update minimum supported Puppet version to 5.5.10
The regexes used in init.pp assumed that the supplied docker version would have to start with 17, however docker is now at 18.
(MODULES-9177) Fix version validation regex
The changes introduced in MODULES-9177 modified the behaviour of docker installs using older versions. The first part of the modified regex ensured that the correct repository was used. As such I have reverted it but left the rest of the changes to ensure that non 17.y.z versions use the correct repo.
(MODULES-9193) Revert part of MODULES-9177
(FM-8151) Add Windows Server 2019 support
fix README typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.