Remove interfering error message #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error message makes it impossible to use xsel in many workflows. I don't think anything is lost by removing it. Also, I've been told by people who have tested this that the isatty() check is not helpful because it returns true; also for pty.
kfish
approved these changes
May 26, 2020
|
Thank you! I don't know anything about the isatty() and pty checks that Stas mentioned, but I hope they might be worth considering. Thank you again! |
|
They were considered, and as the result, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error message makes it impossible to use xsel in many workflows. I don't think anything is lost by removing it.
Also, I've been told by people who have tested this that the isatty() check is not helpful because it returns true; also for pty.