team: mark slug as computed when name changes (integrations#757)

* team: mark slug as computed when name changes

* add test

* vendor

github/resource_github_team.go

@@ -7,6 +7,7 @@ import (
 	"strconv"
 
 	"github.com/google/go-github/v32/github"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/customdiff"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 	"github.com/shurcooL/githubv4"
 )
@@ -21,6 +22,12 @@ func resourceGithubTeam() *schema.Resource {
 			State: schema.ImportStatePassthrough,
 		},
 
+		CustomizeDiff: customdiff.Sequence(
+			customdiff.ComputedIf("slug", func(d *schema.ResourceDiff, meta interface{}) bool {
+				return d.HasChange("name")
+			}),
+		),
+
 		Schema: map[string]*schema.Schema{
 			"name": {
 				Type:     schema.TypeString,

github/resource_github_team_test.go

@@ -151,3 +151,61 @@ func TestAccGithubTeamRemovesDefaultMaintainer(t *testing.T) {
 	})
 
 }
+
+func TestAccGithubTeamUpdateName(t *testing.T) {
+	randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
+
+	t.Run("marks the slug as computed when the name changes", func(t *testing.T) {
+
+		config := fmt.Sprintf(`
+			resource "github_team" "test" {
+				name         = "tf-acc-%s"
+			}
+		`, randomID)
+
+		configUpdated := fmt.Sprintf(`
+			resource "github_team" "test" {
+				name         = "tf-acc-updated-%s"
+			}
+
+			resource "github_team" "other" {
+				name         = "tf-acc-other-%s"
+				description  = github_team.test.slug
+			}
+		`, randomID, randomID)
+
+		testCase := func(t *testing.T, mode string) {
+			resource.Test(t, resource.TestCase{
+				PreCheck:  func() { skipUnlessMode(t, mode) },
+				Providers: testAccProviders,
+				Steps: []resource.TestStep{
+					{
+						Config: config,
+						Check: resource.ComposeTestCheckFunc(
+							resource.TestCheckResourceAttr("github_team.test", "slug", fmt.Sprintf("tf-acc-%s", randomID)),
+						),
+					},
+					{
+						Config: configUpdated,
+						Check: resource.ComposeTestCheckFunc(
+							resource.TestCheckResourceAttr("github_team.other", "description", fmt.Sprintf("tf-acc-updated-%s", randomID)),
+						),
+					},
+				},
+			})
+		}
+
+		t.Run("with an anonymous account", func(t *testing.T) {
+			t.Skip("anonymous account not supported for this operation")
+		})
+
+		t.Run("with an individual account", func(t *testing.T) {
+			t.Skip("individual account not supported for this operation")
+		})
+
+		t.Run("with an organization account", func(t *testing.T) {
+			testCase(t, organization)
+		})
+
+	})
+}

vendor/modules.txt

@@ -249,6 +249,7 @@ github.com/hashicorp/terraform-json
 ## explicit
 github.com/hashicorp/terraform-plugin-sdk/acctest
 github.com/hashicorp/terraform-plugin-sdk/helper/acctest
+github.com/hashicorp/terraform-plugin-sdk/helper/customdiff
 github.com/hashicorp/terraform-plugin-sdk/helper/hashcode
 github.com/hashicorp/terraform-plugin-sdk/helper/logging
 github.com/hashicorp/terraform-plugin-sdk/helper/resource