Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: review code blocks with new metadata #2637

Merged
merged 5 commits into from
Apr 2, 2020

Conversation

jossmac
Copy link
Member

@jossmac jossmac commented Apr 2, 2020

Second pass after #2631 to cleanup any weirdness that the new code block metadata introduced.

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2020

🦋 Changeset is good to go

Latest commit: 2212f74

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Vultraz
Copy link
Contributor

Vultraz commented Apr 2, 2020

Since you're already editing intro-to-graphql, could the method headers ("allUsers", "_allUsersMeta", etc) get properly backticked?

@jossmac jossmac changed the title [WIP] Docs: review code blocks with new metadata Docs: review code blocks with new metadata Apr 2, 2020
@jossmac jossmac merged commit 3a75a41 into master Apr 2, 2020
@jossmac jossmac deleted the chore/docs-review-codeblock-metadata branch April 2, 2020 04:15
@github-actions github-actions bot mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants