Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omitting the blank fields to respect knex DB-level defaults #2347

Merged
merged 14 commits into from
Feb 27, 2020
Merged

Omitting the blank fields to respect knex DB-level defaults #2347

merged 14 commits into from
Feb 27, 2020

Commits on Feb 6, 2020

  1. Omitting the blank fields to respect knex DB-leve defaults 

    While submitting a create list form inside Admin-UI, 'null' was explict
in the mutation request for blank unedited fields. This was preventing
the knex DB-level default to be applied correctly. But omiting the
blank (unchanged) field, we managed to completely exclude it
while making graphql mutation request, and thus respecting the knew `defaultTo`
option.
    Amandeep Singh authored and Amandeep Singh committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    7fb54a8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into knex-db-defaults-form-submit

    @singhArmani
    singhArmani authored Feb 6, 2020
    Configuration menu
    Copy the full SHA
    47cd4a6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/keystonejs/keystone into … 

    …knex-db-defaults-form-submit
    Amandeep Singh authored and Amandeep Singh committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    69fd0fa View commit details
    Browse the repository at this point in the history

  4. Merge branch 'knex-db-defaults-form-submit' of https://github.com/key… 

    …stonejs/keystone into knex-db-defaults-form-submit
    Amandeep Singh authored and Amandeep Singh committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    a019c7f View commit details
    Browse the repository at this point in the history

  5. Omitting the blank fields to respect knex DB-level defaults

    Amandeep Singh authored and Amandeep Singh committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    aef639f View commit details
    Browse the repository at this point in the history

  6. Omitting the blank fields to respect knex DB-level defaults

    Amandeep Singh authored and Amandeep Singh committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    f8222b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Making sure not to omit the required fields in the create form submis… 

    …sion
    Amandeep Singh authored and Amandeep Singh committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    d07d660 View commit details
    Browse the repository at this point in the history

  2. Ran yarn format to fix the prettier issues

    Amandeep Singh authored and Amandeep Singh committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    21183ce View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Merge branch 'master' into knex-db-defaults-form-submit

    @MadeByMike
    MadeByMike authored Feb 10, 2020
    Configuration menu
    Copy the full SHA
    c5a0d3e View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2020

  1. Merge branch 'master' into knex-db-defaults-form-submit

    @timleslie
    timleslie authored Feb 17, 2020
    Configuration menu
    Copy the full SHA
    3161805 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Merge branch 'master' into knex-db-defaults-form-submit

    @MadeByMike
    MadeByMike authored Feb 18, 2020
    Configuration menu
    Copy the full SHA
    d943cb9 View commit details
    Browse the repository at this point in the history

  2. Added changeset

    Amandeep Singh committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    e1a6e34 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into knex-db-defaults-form-submit

    @timleslie
    timleslie authored Feb 18, 2020
    Configuration menu
    Copy the full SHA
    b3086be View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Merge branch 'master' into knex-db-defaults-form-submit

    @timleslie
    timleslie authored Feb 27, 2020
    Configuration menu
    Copy the full SHA
    c42438e View commit details
    Browse the repository at this point in the history