Show loading spinner while loading views in List Table #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR has a changeset ✅ Click here to learn what changesets are. |
jesstelford
force-pushed
the
loader-in-list-table
branch
2 times, most recently
from
b9fe03a
to
13b7d4e
Compare
emmatown
approved these changes
May 5, 2019
jesstelford
force-pushed
the
loader-in-list-table
branch
2 times, most recently
from
447be8f
to
a79062c
Compare
|
@mitchellhamilton I broke the integration tests with this change so had to rework things slightly (just moved the Can I get a re-review? |
emmatown
reviewed
May 7, 2019
| const columns = fields.length + 2; | ||
|
|
||
| const TableContents = ({ isLoading, children }) => | ||
| console.log({ isLoading }) || ( |
There was a problem hiding this comment.
Suggested change
| console.log({ isLoading }) || ( | |
| ( |
jesstelford
force-pushed
the
loader-in-list-table
branch
from
a79062c
to
efc7f0e
Compare
|
🤔 Those two test failures were Cypress being silly - both the elements it claims were invisible are in fact visible in the screenshots and videos.
I've added
Nope, it's exactly the same 👍 |
emmatown
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: PR best viewed with whitespace changes disabled
This moves the loading spinner inside the table which allows the user to interact with the sorting / columns display even while data is loading.
It also implements the things in #1077 so the data and the views can load in parallel.