Generalise loading of multiple Suspense-aware components #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR has a changeset ✅ Click here to learn what changesets are. |
jesstelford
force-pushed
the
parallel-data-and-views
branch
from
cbb98ea
to
8271903
Compare
jesstelford
force-pushed
the
parallel-data-and-views
branch
from
8271903
to
db9f615
Compare
jesstelford
commented
May 2, 2019
| * single Promise, which is itself rethrown. | ||
| * If no Promises are thrown, this is the equivalent of a .map | ||
| */ | ||
| export const captureSuspensePromises = executors => { |
There was a problem hiding this comment.
See the tests below
emmatown
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR best viewed with whitespace disabled
Following on from #1077, this PR makes some of the code more generic (and adds tests!) so that following PRs can apply the pattern to
Cell&Filteralso.