Changed Makefile to use overlay #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuilding with OPTIONS_FLAGS="" will not remove all options. The tests will fail without freemem plugin
dkohlbre
reviewed
Jun 26, 2019
tests/test-qemu.expected.log
Outdated
| # ./test | ||
| # cd tests; ./tests.ke | ||
| Verifying archive integrity... All good. | ||
| Uncompressing Keystone vault archive 0% 47% 95% 100% |
There was a problem hiding this comment.
Is this consistent with the %s? Ideally we'd not check this line since I expect it will change with file size.
There was a problem hiding this comment.
okay. that'd require few lines in the script.
dkohlbre
pushed a commit
that referenced
this pull request
Jul 17, 2019
* Changed Makefile to use overlay * Changed travis files to pass test * Bump riscv-pk and linux-keystone-driver * add makeself package * hifive.mk: rebuild when the overlay directory has been changed * build test app using vault.sh * initialize runtime * Removed wrong travis command and add KEYSTONE_SDK_DIR Rebuilding with OPTIONS_FLAGS="" will not remove all options. The tests will fail without freemem plugin * Wrong KEYSTONE_SDK_DIR set for travis * bump sdk * Separate sdk build from Makefile * Moved SDK and test build to setup scripts * Change setup script and bump runtime * bump sdk and pk to match with documentation * bump sdk and update travis script to ignore decompress msg * Revert "bump sdk and update travis script to ignore decompress msg" This reverts commit 4cf1153. * bump sdk * bump sdk again * bump sdk to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge