Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct type definitions to not use reserved naming #76

Closed
dkohlbre opened this issue Apr 1, 2019 · 2 comments
Closed

Correct type definitions to not use reserved naming #76

dkohlbre opened this issue Apr 1, 2019 · 2 comments
Labels
Housekeeping

Comments

@dkohlbre
Copy link
Collaborator

dkohlbre commented Apr 1, 2019

We are using a lot of _t types we created. These are reserved names.
Current proposal is to move to _kt for keystone-type.

Should we require ALL keystone types to have this naming convention? (Or just typedefs of non-struct types)
dkohlbre pushed a commit to dkohlbre/riscv-pk that referenced this issue May 6, 2019
Removed all definition of _t types, as they are reserved. Renamed to …
6a6fd0f 
…_kt where appropriate for typedefs. All structs are now referenced explictly as structs, not typedefd. See keystone-enclave/keystone#76 .
dkohlbre pushed a commit to dkohlbre/linux-keystone-driver that referenced this issue May 6, 2019
Removed _t type definitions, removed some struct typedefs. See keysto…
b129a08 
…ne-enclave/keystone#76. Also corrected a couple warnings
@dkohlbre dkohlbre mentioned this issue May 6, 2019
Merged
dkohlbre pushed a commit to keystone-enclave/riscv-pk that referenced this issue May 6, 2019
Cleanup pass (#41)
fc2441e 
* Removed old satp checks, that check is now handled by tracking hart state and enforcement in the driver. Standardized the sbi function style

* Removed all definition of _t types, as they are reserved. All structs are now referenced explictly as structs, not typedefd. See keystone-enclave/keystone#76 .

* Removed extraneous aes implementation
@dayeol
Copy link
Contributor

dayeol commented May 9, 2019

@dkohlbre is this resolved?

@dkohlbre
Copy link
Collaborator Author

dkohlbre commented May 9, 2019

Not quite:
keystone-enclave/linux-keystone-driver#15
keystone-enclave/keystone-runtime#16 (waiting on this to do the sdk pr)

dkohlbre pushed a commit to dkohlbre/keystone-sdk that referenced this issue May 10, 2019
Type cleanups to remove reserved _t namings. See keystone-enclave/key…
edda04f 
…stone#76
dkohlbre pushed a commit to keystone-enclave/linux-keystone-driver that referenced this issue May 10, 2019
Removed _t type definitions, removed some struct typedefs. See keysto…
1a71e8d 
…ne-enclave/keystone#76. Also corrected a couple warnings (#15)
dkohlbre pushed a commit to keystone-enclave/keystone-sdk that referenced this issue May 10, 2019
Type cleanups to remove reserved _t namings. See keystone-enclave/key…
c22b97d 
…stone#76 (#25)
dkohlbre pushed a commit to dkohlbre/keystone that referenced this issue May 13, 2019
Bumping submodules for type corrections, see issue keystone-enclave#76
0cb29aa
dkohlbre pushed a commit that referenced this issue May 13, 2019
Bumping submodules for type corrections, see issue #76 (#94)
500bc77 
* Bumping submodules for type corrections, see issue #76

* bumping sdk to restore edge call size behaviors
dkohlbre pushed a commit that referenced this issue Jul 17, 2019
@dkohlbre
Bumping submodules for type corrections, see issue #76 (#94)
da4febf 
* Bumping submodules for type corrections, see issue #76

* bumping sdk to restore edge call size behaviors
dkohlbre added a commit that referenced this issue Jul 17, 2019
@dkohlbre
Revert "Bumping submodules for type corrections, see issue #76 (#94)"
16a2db1 
This reverts commit da4febf.
dayeol pushed a commit to keystone-enclave/sm that referenced this issue Dec 12, 2019
Removed all definition of _t types, as they are reserved. Renamed to …
7f2e14b 
…_kt where appropriate for typedefs. All structs are now referenced explictly as structs, not typedefd. See keystone-enclave/keystone#76 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Housekeeping
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkohlbre @dayeol