Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure management: agent does not reboot on uncaught exception #42

Closed
Unitech opened this issue May 6, 2018 · 0 comments
Closed

failure management: agent does not reboot on uncaught exception #42

Unitech opened this issue May 6, 2018 · 0 comments
Labels
T: Bug

Comments

@Unitech
Copy link
Member

Unitech commented May 6, 2018 •
edited by vmarchaud
Loading

The rescue system based on domain has not been implemented. Uncaught exception crash the whole agent.

Legacy agent rescue system:
https://github.com/Unitech/pm2/blob/19601695249ecbd6b6a822bebe101e07ffbd7991/lib/Interactor/Daemon.js#L313

New agent rescue system (none):
https://github.com/keymetrics/keymetrics-agent/blob/master/src/InteractorDaemon.js#L280
@Unitech Unitech added the T: Bug label May 6, 2018
@Unitech Unitech mentioned this issue May 6, 2018
Closed
14 tasks
@Unitech Unitech changed the title critical issue: agent does not reboot on uncaught exception failure management: agent does not reboot on uncaught exception May 6, 2018
Unitech added a commit that referenced this issue May 10, 2018
@Unitech
#42
fabe35f
@Unitech Unitech closed this as completed May 10, 2018
vmarchaud pushed a commit that referenced this issue May 15, 2018
@Unitech @vmarchaud
daemon: catch error and restart itself #42
a722234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Unitech