Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to hold down until trigger is pressed again #479

Closed
3 tasks done
sds100 opened this issue Oct 11, 2020 · 3 comments
Closed
3 tasks done

option to hold down until trigger is pressed again #479

sds100 opened this issue Oct 11, 2020 · 3 comments
Assignees
@sds100
Labels
enhancement New feature or request

Comments

@sds100
Copy link
Collaborator

sds100 commented Oct 11, 2020 •
edited
Loading

  • make the Repeat and Hold Down options mutually exclusive. Merge into 2.1. Migrate user data that has hold-down enabled AND repeat enabled to just have repeat enabled. very few users will have done this in the Beta and they can contact us if they have an issue.
  • show radio buttons like for repeat until pressed again
  • change algorithm in KeymapDetectionDelegate
@sds100 sds100 added the enhancement New feature or request label Oct 11, 2020
@sds100 sds100 self-assigned this Oct 11, 2020
sds100 added a commit that referenced this issue Oct 27, 2020
@sds100
#479 make Hold Down and Repeat action options mutually exclusive and …
743b3f2 
…migrate user data for this change
@sds100
Copy link
Collaborator Author

sds100 commented Oct 27, 2020

squeezing into 2.1 release because it affects how data is stored in the database. I want as few users as possible on an outdated schema.

sds100 added a commit that referenced this issue Oct 27, 2020
@sds100
#479 don't allow Repeat and Hold Down to be turned on at the same time
301ffbe
sds100 added a commit that referenced this issue Oct 27, 2020
@sds100
#479 show radio buttons to hold down until trigger is released or pre…
5e5d42d 
…ssed again
@sds100
Copy link
Collaborator Author

sds100 commented Oct 28, 2020

implemented

@sds100 sds100 closed this as completed Oct 28, 2020
sds100 added a commit that referenced this issue Oct 28, 2020
@sds100
#479 don't allow Repeat and Hold Down to be turned on at the same time
51ce413
sds100 added a commit that referenced this issue Oct 28, 2020
@sds100
Revert "#479 don't allow Repeat and Hold Down to be turned on at the …
0c63c68 
…same time"

This reverts commit 51ce413.
sds100 added a commit that referenced this issue Oct 28, 2020
@sds100
#479 make Hold Down and Repeat action options mutually exclusive and …
94d1ee6 
…migrate user data for this change
sds100 added a commit that referenced this issue Oct 28, 2020
@sds100
#479 don't allow Repeat and Hold Down to be turned on at the same time
e558985
@sds100
Copy link
Collaborator Author

sds100 commented Oct 28, 2020

only making Hold Down and Repeat mutually exclusive has been merged into 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sds100 sds100

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sds100