[KEYCLOAK-16126] - Windows support #7588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroigor
force-pushed
the
KEYCLOAK-16126
branch
from
200932e to
3928055
Compare
pedroigor
force-pushed
the
KEYCLOAK-16126
branch
2 times, most recently
from
e63d8b5 to
91f8d02
Compare
pedroigor
force-pushed
the
KEYCLOAK-16126
branch
from
91f8d02 to
d243863
Compare
mposolda
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
kc.batscriptMain fix:
kc.bat configdoes not work due to how Windows handles file lock.To workaround the file lock issue on Windows, I had to hack the runtime classloader so that JAR files that are (re)generated when running the
configcommand are closed prior to running Quarkus re-augmentation. Classes from these JARs are only used when actually running the application and should be safe to be ignored.The workaround should be fixed on Quarkus by quarkusio/quarkus#13202. Meanwhile, we can live with this workaround.