Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Quarkus Platform BOMs #20570

Closed
Tracked by #21356
vmuzikar opened this issue May 25, 2023 · 5 comments · Fixed by #21426
Closed
Tracked by #21356

Use Quarkus Platform BOMs #20570

vmuzikar opened this issue May 25, 2023 · 5 comments · Fixed by #21426

Comments

@vmuzikar
Copy link
Contributor

vmuzikar commented May 25, 2023

Description

To further align with Quarkus, we should be using the Platform BOMs. In particular:

An alternative is to use a single BOM io.quarkus:quarkus-universe-bom.

This also includes cleaning up the dependency overrides we no longer need.

@vmuzikar vmuzikar added this to the 22.0.0 milestone May 25, 2023
@vmuzikar vmuzikar self-assigned this May 25, 2023
@ghost ghost added the team/cloud-native label May 25, 2023
@vmuzikar
Copy link
Contributor Author

@ASzc Is this ok for productization?

@ASzc
Copy link
Contributor

ASzc commented May 25, 2023

I think we'll need to be kept in the loop so the product build parameters can be updated when needed. However, this shouldn't cause problems

@ASzc
Copy link
Contributor

ASzc commented May 25, 2023

Marginal preference for io.quarkus.platform BOMs. I'm not sure if this universe bom appears in RHBQ

@vmuzikar vmuzikar removed their assignment Jun 2, 2023
@vmuzikar
Copy link
Contributor Author

vmuzikar commented Jun 6, 2023

Based on discussion with Quarkus team, we should be using the combination of io.quarkus.platform BOMs.

@vmuzikar
Copy link
Contributor Author

vmuzikar commented Jun 6, 2023

WIP branch (with lots of failed tests :)): https://github.com/vmuzikar/keycloak/tree/platform-bom

Pepo48 added a commit to Pepo48/keycloak that referenced this issue Jul 2, 2023
* added Quarkus Platform BOM
* added Quarkus Operator SDK BOM

Closes keycloak#20570

Signed-off-by: Peter Zaoral <[email protected]>
vmuzikar pushed a commit to vmuzikar/keycloak that referenced this issue Jul 4, 2023
Closes keycloak#20570
Closes keycloak#15870

Co-authored-by: Peter Zaoral <[email protected]>
abstractj pushed a commit that referenced this issue Jul 6, 2023
Closes #20570
Closes #15870

Co-authored-by: Peter Zaoral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants