Skip to content

Commit

Permalink
Quarkus IT that use Oracle DB don't work with -Dproduct (#23088)
Browse files Browse the repository at this point in the history
Fixes #23058
  • Loading branch information
mabartos authored Sep 8, 2023
1 parent f52af8d commit 1d15f1e
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 1 deletion.
12 changes: 12 additions & 0 deletions quarkus/tests/integration/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,23 @@
<artifactId>bctls-fips</artifactId>
<scope>test</scope>
</dependency>

<!-- JDBC Drivers -->
<dependency>
<groupId>com.microsoft.sqlserver</groupId>
<artifactId>mssql-jdbc</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.oracle.database.jdbc</groupId>
<artifactId>ojdbc11</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.oracle.database.nls</groupId>
<artifactId>orai18n</artifactId>
<scope>test</scope>
</dependency>

<!-- Minimal test dependencies to *-deployment artifacts for consistent build order -->
<dependency>
Expand Down
11 changes: 11 additions & 0 deletions quarkus/tests/junit5/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,21 @@
<groupId>org.testcontainers</groupId>
<artifactId>mssqlserver</artifactId>
</dependency>

<!-- JDBC Drivers -->
<dependency>
<groupId>com.microsoft.sqlserver</groupId>
<artifactId>mssql-jdbc</artifactId>
</dependency>
<dependency>
<groupId>com.oracle.database.jdbc</groupId>
<artifactId>ojdbc11</artifactId>
</dependency>
<dependency>
<groupId>com.oracle.database.nls</groupId>
<artifactId>orai18n</artifactId>
</dependency>

<dependency>
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-shared</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -389,9 +389,12 @@ private Path prepareDistribution() {
if (!inited || (reCreate || !dPath.toFile().exists())) {
FileUtil.deleteDirectory(dPath);
ZipUtils.unzip(distFile.toPath(), distRootPath);

if (System.getProperty("product") != null) {
// MS SQL Server driver might be excluded if running as a product build
// JDBC drivers might be excluded if running as a product build
copyProvider(dPath, "com.microsoft.sqlserver", "mssql-jdbc");
copyProvider(dPath, "com.oracle.database.jdbc", "ojdbc11");
copyProvider(dPath, "com.oracle.database.nls", "orai18n");
}
}

Expand Down

0 comments on commit 1d15f1e

Please sign in to comment.