Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract library #1

Merged
merged 10 commits into from
Oct 27, 2018
Merged

Extract library #1

merged 10 commits into from
Oct 27, 2018

Conversation

ligi
Copy link
Contributor

@ligi ligi commented Oct 26, 2018

This way it can be consumed by other applications. If you merge it and set a tag I can add a README and instructions how to consume it via @jitpack

@ligi ligi force-pushed the extract_library branch 2 times, most recently from 63c9029 to 4a9c662 Compare October 26, 2018 21:08
Also change the logging as we do not have the byte[]->hex method from spongycastle anymore
Copy link
Collaborator

@bitgamma bitgamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitgamma bitgamma merged commit 8950e15 into keycard-tech:master Oct 27, 2018
ligi added a commit to walleth/KHardWareWallet that referenced this pull request Oct 27, 2018
@ligi
Copy link
Contributor Author

ligi commented Oct 27, 2018

Thanks for the merge. Are you back in the venue btw. would love to have a small chat - collected some questions ;-)

@ligi ligi deleted the extract_library branch October 28, 2018 11:31
GreyRabbitty added a commit to GreyRabbitty/ether-wallet that referenced this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants