Add generated types #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
September 4, 2019 18:27
nathanmsmith
commented
Sep 6, 2019
| return json.loads(response) | ||
| parsed_response = json.loads(response) | ||
| if "error" in parsed_response: | ||
| raise Exception(parsed_response["error"]) |
There was a problem hiding this comment.
Pass errors from the service through
xgess
reviewed
Sep 6, 2019
examples/2_get_paid.py
Outdated
| @@ -30,13 +31,17 @@ class Handler: | |||
| async def __call__(self, bot, event): | |||
| if event.type != EventType.WALLET: | |||
| return | |||
| if event.notification.statusDescription != PaymentStatusStr.COMPLETED: | |||
| print(event.notification) | |||
xgess
reviewed
Sep 6, 2019
|
|
||
| logging.basicConfig(level=logging.DEBUG) | ||
|
|
||
|
|
||
| async def handler(bot, event): | ||
| if event.msg.content.type != ContentType.TEXT: | ||
| if event.msg.content.type_name != chat1.MessageTypeStrings.TEXT.value: |
There was a problem hiding this comment.
chat1.MessageTypeStrings.TEXT.value <-- this is pretty unfortunate for something as common as this '__'
xgess
reviewed
Sep 6, 2019
| return | ||
| channel = event.msg.channel | ||
| msg_id = event.msg.id | ||
| await bot.chat.react(channel.replyable_dict(), msg_id, ":clap:") | ||
| await bot.chat.react(channel, msg_id, ":clap:") |
xgess
reviewed
Sep 6, 2019
|
|
||
| logging.basicConfig(level=logging.DEBUG) | ||
|
|
||
|
|
||
| class Handler: | ||
| async def __call__(self, bot, event): | ||
| if event.msg.content.type != ContentType.TEXT: | ||
| if event.msg.content.type_name != chat1.MessageTypeStrings.TEXT.value: |
There was a problem hiding this comment.
i feel like no one is actually going to do this. they'll just write "text" here instead. 🙃
xgess
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generated types to the python bot.
I tried to add type hinting where it makes sense, but we won't get full type coverage at least until lidatong/dataclasses-json#23 is resolved. We still get the big win of having all dataclasses defined.
All examples and tests should work. A few dataclass field names were changed in the process.
Note that chat methods now take dataclasses and input and return dataclasses as output, as opposed to dicts as we did previously.