Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: use dataclasses_json mixin instead of decorator #46

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Python: use dataclasses_json mixin instead of decorator #46

merged 3 commits into from
Oct 14, 2019

Conversation

nathanmsmith
Copy link
Contributor

Mypy is bad at detecting types from decorators (see lidatong/dataclasses-json#23), so the mixin will give us the typing support we want.

xgess
xgess approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@xgess xgess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanmsmith
Copy link
Contributor Author

@maxtaco I think we should cut a 1.4.5 release for this. I updated the changelog already in this PR

@nathanmsmith nathanmsmith merged commit b677eeb into master Oct 14, 2019
@nathanmsmith nathanmsmith deleted the nathan/mypy-fixes branch October 14, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgess xgess xgess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanmsmith @xgess