Add support for changing kSecUseDataProtectionKeychain #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you'd need to do this a seperate fork since this is only supported in Catalina and there are no golang build contraints for macos versions? Also this fork could automatically enable it on new items by default as suggested by the documentation. |
Rename variables and functions to match Apple
|
With pre-Catalina being EOL, this should be safe to merge now? |
joshblum
reviewed
Mar 7, 2023
| @@ -303,6 +320,11 @@ func (k *Item) SetSynchronizable(sync Synchronizable) { | |||
| } | |||
| } | |||
|
|
|||
| // SetSynchronizable sets the synchronizable attribute | |||
There was a problem hiding this comment.
Suggested change
| // SetSynchronizable sets the synchronizable attribute | |
| // SetUseDataProtectionKeychain sets the data protection attribute |
|
Hi folks, friendly 2024 bump on this. Any appetite to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was added in Catalina and is required if you are using Keychain access groups.