Upgrade Electron to 1.8.4 #11204
Merged
Upgrade Electron to 1.8.4 #11204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnojima
reviewed
Apr 4, 2018
|
ok since this needs as much testing as teh webpack build and this is a bnrach i'm merging this down |
chrisnojima
reviewed
Apr 4, 2018
| @@ -146,7 +146,6 @@ | |||
| "@babel/cli": "^7.0.0-beta.42", | |||
| "@babel/core": "^7.0.0-beta.42", | |||
| "@babel/node": "^7.0.0-beta.42", | |||
| "@babel/plugin-proposal-class-properties": "^7.0.0-beta.42", | |||
There was a problem hiding this comment.
atcually i think we can't do this. our node needs this and electrons node also needs this, even if chromium does not
chrisnojima
added a commit
that referenced
this pull request
Apr 10, 2018
… to desktop (#11232) * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * fix rn storybook * WIP * WIP * WIP * WIP * remove react infection in usertimings * Upgrade Electron to 1.8.4 (#11204) * bring back class properties * WIP * WIP * use componentDidMount vs willMount. Add StrictMode to desktop * componentWillReceiveProps changes 1 (#11233) * WIP * wip * WIP * WIP * remove strictmode. remove _mounted (already a hoc so its protected) . add return null from getDerived
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keybase/react-hackers
This lets us stop using the plugin-proposal-class-properties transformation, since new Electron can handle it. The other two plugins are still necessary.