CI: Add python formatting to pre-commit and make all files comply

.github/workflows/pre-commit.yml

@@ -6,18 +6,21 @@ jobs:
   pre-commit:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: cvmfs-contrib/github-action-cvmfs@v3.1
+    - uses: actions/checkout@v4
+    - uses: cvmfs-contrib/github-action-cvmfs@v4
     - uses: aidasoft/run-lcg-view@v4
       with:
-        release-platform: LCG_101/x86_64-centos7-clang12-opt
+        container: el9
+        view-path: /cvmfs/sw-nightlies.hsf.org/key4hep
         run: |
-          export PYTHONPATH=$(python -m site --user-site):$PYTHONPATH
-          export PATH=/root/.local/bin:$PATH
-          pip install --upgrade --user pip
-          pip install pre-commit --user
-          # Use virtualenv from the LCG release
-          pip uninstall --yes virtualenv
+          python -m venv /root/pre-commit-venv
+          source /root/pre-commit-venv/bin/activate
+          pip install pre-commit
+          export PYTHONPATH=$VIRTUAL_ENV/lib/python3.$(python3 -c 'import sys; print(f"{sys.version_info[1]}")')/site-packages:$PYTHONPATH
+          # Newer versions of git are more cautious around the github runner
+          # environment and without this git rev-parse --show-cdup in pre-commit
+          # fails
+          git config --global --add safe.directory $(pwd)
           pre-commit run --show-diff-on-failure \
             --color=always \
             --all-files

.pre-commit-config.yaml

@@ -3,3 +3,10 @@ repos:
     rev: v4.5.0
     hooks:
       - id: check-xml
+  - repo: local
+    hooks:
+      - id: ruff-format
+        name: ruff-format
+        entry: ruff format --force-exclude
+        types: [python]
+        language: system

.ruff.toml

@@ -0,0 +1,10 @@
+target-version = "py311"
+
+line-length = 99
+
+[format]
+# Make things format the same way as black
+quote-style = "double"
+indent-style = "space"
+skip-magic-trailing-comma = false
+line-ending = "auto"

CaloTB/CaloTB_EPT_AHCAL/TBModel2015_steering.py

@@ -6,33 +6,38 @@
 SIM.compactFile = "../../DD4HEP/compact/TBModel2015.xml"
 SIM.runType = "batch"
 SIM.macroFile = "vis.mac"
-#SIM.inputFiles = "mcparticles.slcio"
+# SIM.inputFiles = "mcparticles.slcio"
 SIM.outputFile = "DD4hep_mu-_8GeV_QGSP_BERT_10k.slcio"
 
 SIM.numberOfEvents = 10000
 SIM.skipNEvents = 0
 SIM.physicsList = "QGSP_BERT"
 SIM.dumpSteeringFile = "TBModel2015_dump.xml"
-SIM.enableDetailedShowerMode=True
+SIM.enableDetailedShowerMode = True
 
 SIM.random.seed = "0123456789"
-SIM.field.eps_min = 1*mm
-SIM.part.minimalKineticEnergy = 1*MeV
+SIM.field.eps_min = 1 * mm
+SIM.part.minimalKineticEnergy = 1 * MeV
 
 SIM.action.calo = "Geant4ScintillatorCalorimeterAction"
 
 ## set the particle.tbl file to add extra particles to DDsim (B-Baryons)
 ## use the power of python to get the file from DD4hep wherever it is
 import os
-if os.path.exists( os.path.join( os.environ.get("DD4hepINSTALL"), "examples/DDG4/examples/particle.tbl") ):
-  SIM.physics.pdgfile = os.path.join( os.environ.get("DD4hepINSTALL"), "examples/DDG4/examples/particle.tbl")
+
+if os.path.exists(
+    os.path.join(os.environ.get("DD4hepINSTALL"), "examples/DDG4/examples/particle.tbl")
+):
+    SIM.physics.pdgfile = os.path.join(
+        os.environ.get("DD4hepINSTALL"), "examples/DDG4/examples/particle.tbl"
+    )
 
 
 SIM.enableGun = True
 SIM.gun.particle = "mu-"
-SIM.gun.energy = 8*GeV
+SIM.gun.energy = 8 * GeV
 SIM.gun.position = "0, 0, -1000"
 SIM.gun.direction = "0,0,1"
 
-#SIM.gun.isotrop
+# SIM.gun.isotrop
 SIM.gun.multiplicity = 1

CaloTB/run_sim/ddsim_steering_00.py

@@ -12,19 +12,19 @@
 SIM.compactFile = "../compact/MainTestBeamSetup.xml"
 SIM.dumpSteeringFile = "dumpSteering00.xml"
 
-SIM.field.eps_min = 1*mm
+SIM.field.eps_min = 1 * mm
 
-SIM.part.minimalKineticEnergy = 1*MeV
+SIM.part.minimalKineticEnergy = 1 * MeV
 
 SIM.physicsList = "QGSP_BERT"
-   
-SIM.enableDetailedShowerMode=True
+
+SIM.enableDetailedShowerMode = True
 
 SIM.enableGun = True
 
-SIM.gun.energy = 10*GeV
+SIM.gun.energy = 10 * GeV
 SIM.gun.particle = "pi+"
-#SIM.gun.multiplicity
+# SIM.gun.multiplicity
 SIM.gun.position = "0,0,-1000"
-#SIM.gun.isotrop
+# SIM.gun.isotrop
 SIM.gun.direction = "0,0,1"