-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ParticleID collection into smaller collections #131
Conversation
bc92e5c
to
ad07238
Compare
55a6b1e
to
183a804
Compare
@kjvbrt @BrieucF as you will probably have inferred from HEP-FCC/FCCAnalyses#411 this will have an effect there as well. I think it should make things a bit easier on the function implementation side, because there is less index hopping involved now. On the other hand users will now have to deal with potentially multiple ParticleID collections. Also just as a reminder: Most of the functions that deal with ParticleID in FCCAnalyses will have to be changed in any case since key4hep/EDM4hep#268 changed the direction of the relation. |
183a804
to
1bacea7
Compare
As far as I'm aware, the only code for reading the jet tags from Delphes is in the FCC-hh analyzer that I have adapted in HEP-FCC/FCCAnalyses#411. If this is not true and I have missed something, please let me know in the PR and I will adapt the code. For the track PIDs I'm not sure if they are used, but I'm happy to adapt code as needed there as well (on FCCAnalyses side). |
I like the idea, this will also help with how many PIDs will need to be searched, right? |
Yes, it should make working with PIDs in general (also outside of FCCAnalyses) easier because you don't have to do some specific filtering according to e.g. the
The |
Having one large ParticleID collection made sense historically before EDM4hep reversed the direction of the ReconstructedParticle -> ParticleID relation. Since now ParticleIDs point to the ReconstructedParticles it's easier to handle downstream (and especially in FCCAnalyses) if there are several smaller and more specific ParticleID collections for each of the input collections that are converted.
1bacea7
to
f45a960
Compare
We discussed this in the FCCAnalyses chat today with @kjvbrt and @jeyserma and it seems there is no (officially supported) FCCAnalyses code relying on this. |
There is function |
BEGINRELEASENOTES
ParticleIDs
collection into several smaller collections to facilitate downstream usage after the reversal of theParticleID
-ReconstructedParticle
relation direction in EDM4hep#268.Tracks
will get aParticleIDCollection
with the suffix_PID
Jets
will get aParticleIDCollection
with the suffix_HF_tags
for any heavy flavor tags, and_tau_tags
for any tau tags.ENDRELEASENOTES
Having one large ParticleID collection made sense historically before EDM4hep reversed the direction of the ReconstructedParticle -> ParticleID relation. Since now ParticleIDs point to the ReconstructedParticles it's easier to handle downstream (and especially in FCCAnalyses) if there are several smaller and more specific ParticleID collections for each of the input collections that are converted.
@bistapf since we are at it should we also think about splitting the tags for the jets into separate collections?