Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to copy CellID metadata when overlaying #12

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

jmcarcell
Copy link
Contributor

BEGINRELEASENOTES

  • Add an option to copy CellID metadata when overlaying, so that the new collections can be equivalent to the old ones.

ENDRELEASENOTES

For example in the Marlin wrapper even if renaming the new collections to the old names, the wrapper will look for metadata using the new names.

@@ -140,6 +141,9 @@ struct OverlayTiming : public k4FWCore::MultiTransformer<retType(
this, "TimeWindows", std::map<std::string, std::vector<float>>(), "Time windows for the different collections"};
Gaudi::Property<bool> m_allowReusingBackgroundFiles{
this, "AllowReusingBackgroundFiles", false, "If true the same background file can be used for the same event"};
Gaudi::Property<bool> m_copyCellIDMetadata{this, "CopyCellIDMetadata", false,
"If metadata is found in the signal file, copy it to the output file, "
Copy link
Contributor

@andresailer andresailer Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which names are replaced?
And is there ever a case where we wouldn't want this to be done?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the ones that are InputCollection__CellIDEncoding (the convention in DD4hep) are changed to OutputCollection__CellIDEncoding. If for some reason the convention is different then I guess we wouldn't want this but there is no general way of finding the metadata associated to an input collection since from the algorithm there isn't a way of knowing all the names of the metadata parameters (which would allow for looking for a name that contains the current input collection). If the option is removed then there would be some warnings if the metadata paremeters are not found.

@andresailer andresailer merged commit 6ec424d into main Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants